Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2204873005: Update hardstop_gradients GM to include more special cases (Closed)

Created:
4 years, 4 months ago by fmenozzi
Modified:
4 years, 4 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update hardstop_gradients GM to include more special cases BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2204873005 Committed: https://skia.googlesource.com/skia/+/7a9f3766aa07f69323f37670a7aeb13605f266bb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M gm/hardstop_gradients.cpp View 1 4 chunks +36 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
fmenozzi
Now that we have more special cases to consider (centered hard stop, 001, 011 edge ...
4 years, 4 months ago (2016-08-03 13:46:32 UTC) #3
tomhudson
lgtm https://codereview.chromium.org/2204873005/diff/1/gm/hardstop_gradients.cpp File gm/hardstop_gradients.cpp (right): https://codereview.chromium.org/2204873005/diff/1/gm/hardstop_gradients.cpp#newcode21 gm/hardstop_gradients.cpp:21: * 3-color texture | rect20 rect21 rect22 I ...
4 years, 4 months ago (2016-08-03 14:14:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204873005/20001
4 years, 4 months ago (2016-08-03 14:34:12 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 14:58:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7a9f3766aa07f69323f37670a7aeb13605f266bb

Powered by Google App Engine
This is Rietveld 408576698