Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2204873003: Add WeakCell support to heap profiler. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add WeakCell support to heap profiler. Committed: https://crrev.com/aba8a8151e4ee51afcaf9027ea8316bb7c888df3 Cr-Commit-Position: refs/heads/master@{#38245}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/profiler/heap-snapshot-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
alph
4 years, 4 months ago (2016-08-02 12:26:42 UTC) #2
ulan
lgtm, feel free to ignore the suggestion below: https://codereview.chromium.org/2204873003/diff/1/src/profiler/heap-snapshot-generator.cc File src/profiler/heap-snapshot-generator.cc (right): https://codereview.chromium.org/2204873003/diff/1/src/profiler/heap-snapshot-generator.cc#newcode1492 src/profiler/heap-snapshot-generator.cc:1492: SetWeakReference(weak_cell, ...
4 years, 4 months ago (2016-08-02 12:32:17 UTC) #3
alph
https://codereview.chromium.org/2204873003/diff/1/src/profiler/heap-snapshot-generator.cc File src/profiler/heap-snapshot-generator.cc (right): https://codereview.chromium.org/2204873003/diff/1/src/profiler/heap-snapshot-generator.cc#newcode1492 src/profiler/heap-snapshot-generator.cc:1492: SetWeakReference(weak_cell, entry, "next", weak_cell->next(), On 2016/08/02 12:32:17, ulan wrote: ...
4 years, 4 months ago (2016-08-02 13:00:12 UTC) #4
ulan
lgtm
4 years, 4 months ago (2016-08-02 13:07:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204873003/20001
4 years, 4 months ago (2016-08-02 13:17:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 13:40:43 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 13:44:09 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/aba8a8151e4ee51afcaf9027ea8316bb7c888df3
Cr-Commit-Position: refs/heads/master@{#38245}

Powered by Google App Engine
This is Rietveld 408576698