Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 2204873003: Add WeakCell support to heap profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 8e91e4742fdc258c2e565f99c810aa3b2f4cfc77..637bda144b4b6666de0f322b083f1d02dd03318e 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -692,7 +692,9 @@ TEST(HeapSnapshotMap) {
CHECK(GetProperty(map, v8::HeapGraphEdge::kInternal, "prototype"));
CHECK(GetProperty(map, v8::HeapGraphEdge::kInternal, "back_pointer"));
CHECK(GetProperty(map, v8::HeapGraphEdge::kInternal, "descriptors"));
- CHECK(GetProperty(map, v8::HeapGraphEdge::kInternal, "weak_cell_cache"));
+ const v8::HeapGraphNode* weak_cell =
+ GetProperty(map, v8::HeapGraphEdge::kInternal, "weak_cell_cache");
+ CHECK(GetProperty(weak_cell, v8::HeapGraphEdge::kWeak, "value"));
}
TEST(HeapSnapshotInternalReferences) {
« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698