Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2204773003: Add bounds checks to CWeightTable::Calc() and friends. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add bounds checks to CWeightTable::Calc() and friends. BUG=624514 Committed: https://pdfium.googlesource.com/pdfium/+/766901f5ec79b3c3ccd1e872f699642d771a89c5

Patch Set 1 #

Patch Set 2 : const #

Patch Set 3 : handle one more failure and return early #

Total comments: 2

Patch Set 4 : store size #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -64 lines) Patch
M core/fxge/dib/dib_int.h View 1 2 3 1 chunk +12 lines, -10 lines 0 comments Download
M core/fxge/dib/fx_dib_engine.cpp View 1 2 3 19 chunks +120 lines, -54 lines 2 comments Download

Messages

Total messages: 20 (12 generated)
Lei Zhang
4 years, 4 months ago (2016-08-02 02:17:26 UTC) #6
Lei Zhang
CWeightTable::Calc() may be doing calculation incorrectly, but when I tried to fix them so that ...
4 years, 4 months ago (2016-08-02 02:19:09 UTC) #7
Tom Sepez
https://codereview.chromium.org/2204773003/diff/40001/core/fxge/dib/fx_dib_engine.cpp File core/fxge/dib/fx_dib_engine.cpp (right): https://codereview.chromium.org/2204773003/diff/40001/core/fxge/dib/fx_dib_engine.cpp#newcode240 core/fxge/dib/fx_dib_engine.cpp:240: if (pWeight >= m_pWeightTablesEnd) We'll want to store the ...
4 years, 4 months ago (2016-08-02 18:14:10 UTC) #8
Lei Zhang
https://codereview.chromium.org/2204773003/diff/40001/core/fxge/dib/fx_dib_engine.cpp File core/fxge/dib/fx_dib_engine.cpp (right): https://codereview.chromium.org/2204773003/diff/40001/core/fxge/dib/fx_dib_engine.cpp#newcode240 core/fxge/dib/fx_dib_engine.cpp:240: if (pWeight >= m_pWeightTablesEnd) On 2016/08/02 18:14:10, Tom Sepez ...
4 years, 4 months ago (2016-08-04 06:34:02 UTC) #14
Tom Sepez
lgtm https://codereview.chromium.org/2204773003/diff/80001/core/fxge/dib/fx_dib_engine.cpp File core/fxge/dib/fx_dib_engine.cpp (right): https://codereview.chromium.org/2204773003/diff/80001/core/fxge/dib/fx_dib_engine.cpp#newcode258 core/fxge/dib/fx_dib_engine.cpp:258: size_t idx = index - pWeight->m_SrcStart; Technically, this ...
4 years, 4 months ago (2016-08-04 17:21:59 UTC) #15
Tom Sepez
https://codereview.chromium.org/2204773003/diff/80001/core/fxge/dib/fx_dib_engine.cpp File core/fxge/dib/fx_dib_engine.cpp (right): https://codereview.chromium.org/2204773003/diff/80001/core/fxge/dib/fx_dib_engine.cpp#newcode258 core/fxge/dib/fx_dib_engine.cpp:258: size_t idx = index - pWeight->m_SrcStart; On 2016/08/04 17:21:58, ...
4 years, 4 months ago (2016-08-04 17:28:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204773003/80001
4 years, 4 months ago (2016-08-04 17:34:27 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 17:34:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/766901f5ec79b3c3ccd1e872f699642d771a...

Powered by Google App Engine
This is Rietveld 408576698