Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220473008: Remove software path from filters: FEColorMatrix. (Closed)

Created:
6 years, 8 months ago by Savago
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove software path from filters: FEColorMatrix. BUG=357672 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170612

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove matrix() and others. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -137 lines) Patch
M Source/platform/graphics/filters/FEColorMatrix.h View 2 chunks +0 lines, -30 lines 0 comments Download
M Source/platform/graphics/filters/FEColorMatrix.cpp View 1 4 chunks +4 lines, -107 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Savago
Next step on cleanup: FEColorMatrix.
6 years, 8 months ago (2014-04-01 20:14:26 UTC) #1
Stephen White
LGTM
6 years, 8 months ago (2014-04-01 20:24:22 UTC) #2
Savago
https://codereview.chromium.org/220473008/diff/1/Source/platform/graphics/filters/FEColorMatrix.cpp File Source/platform/graphics/filters/FEColorMatrix.cpp (right): https://codereview.chromium.org/220473008/diff/1/Source/platform/graphics/filters/FEColorMatrix.cpp#newcode100 Source/platform/graphics/filters/FEColorMatrix.cpp:100: inline void luminance(float& red, float& green, float& blue, float& ...
6 years, 8 months ago (2014-04-01 20:58:09 UTC) #3
Savago
The CQ bit was checked by a.cavalcanti@samsung.com
6 years, 8 months ago (2014-04-01 22:07:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.cavalcanti@samsung.com/220473008/20001
6 years, 8 months ago (2014-04-01 22:43:24 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 23:59:20 UTC) #6
Message was sent while issue was closed. 
Change committed as 170612

Powered by Google App Engine
This is Rietveld 408576698