scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json - Issue 2204643002: [Android] Add failures to results log line for Host Info step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json

Issue 2204643002: [Android] Add failures to results log line for Host Info step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json ('k') | scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json » ('j') | scripts/slave/recipes/android/perf.expected/host_info_failure.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json

diff --git a/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json b/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json

index da61d33fe21fb0d577d7cd7384f1839dfffdf78e..af5bf422a496fd47a895463fc9507f9ab8228d25 100644

--- a/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json

+++ b/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json

@@ -497,11 +497,7 @@

"@@@STEP_LOG_LINE@json.output@ ], @@@",

"@@@STEP_LOG_LINE@json.output@ \"valid\": true@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",

- "@@@STEP_LOG_END@json.output@@@",

- "@@@STEP_LOG_LINE@Failure A@Failure A@@@",

martiniss 2016/08/02 00:44:29 Are you sure you want these failure logs going awa

rnephew (Reviews Here) 2016/08/02 01:03:49 Yeah,there should be no failure detected on this o

- "@@@STEP_LOG_END@Failure A@@@",

- "@@@STEP_LOG_LINE@Failure B@Failure B@@@",

- "@@@STEP_LOG_END@Failure B@@@"

+ "@@@STEP_LOG_END@json.output@@@"

]

{