Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2204643002: [Android] Add failures to results log line for Host Info step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index b7c5c9ac41b76f69e19c5d1026d2b025c2c688a1..7a99fa00f56837c908a380bf3d229e8285a5c37a 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -420,12 +420,10 @@ class AndroidApi(recipe_api.RecipeApi):
}}),
**kwargs)
return results
- except self.m.step.InfraFailure:
- pass
- finally:
- if results:
- for failure in results.json.output.get('failures', []):
- results.presentation.logs[failure] = [failure]
+ except self.m.step.InfraFailure as f:
+ for failure in f.result.json.output.get('failures', []):
+ f.result.presentation.logs[failure] = [failure]
+ f.result.presentation.status = self.m.step.FAILURE
jbudorick 2016/08/01 23:29:21 Will this turn the step red rather than purple?
martiniss 2016/08/02 00:44:29 yes
rnephew (Reviews Here) 2016/08/02 01:03:49 c/p the wrong line. Fixed.
def device_recovery(self, restart_usb=False, **kwargs):
args = [

Powered by Google App Engine
This is Rietveld 408576698