[Android] Add failures to results log line for Host Info step.

[Android] Add failures to results log line for Host Info step.

BUG=592140
Committed: https://chromium.googlesource.com/chromium/tools/build/+/18ec037fcdf5072a4d169859adfc4467335bba5d

[rnephew (Reviews Here), 2016-08-01 22:17:34]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, stip@chromium.org

[rnephew (Reviews Here), 2016-08-01 22:17:35]

Third try is the charm? Based off expectation files, it should work as expected
this time; I was reading them wrong before.

[ghost stip (do not use), 2016-08-01 23:27:28]

Description was changed from

==========
[Android] Add failures to results log line for Host Info step.

BUG=592140
==========

to

==========
[Android] Add failures to results log line for Host Info step.

BUG=592140
==========

[ghost stip (do not use), 2016-08-01 23:27:28]

stip@chromium.org changed reviewers:
+ martiniss@chromium.org

[ghost stip (do not use), 2016-08-01 23:27:41]

I don't really know the machinery here, maybe martiniss@ does.

[jbudorick, 2016-08-01 23:29:22]

oh, yeah, I guess this makes sense as to why it never hit :|

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/api.py:426:
f.result.presentation.status = self.m.step.FAILURE
Will this turn the step red rather than purple?

[martiniss, 2016-08-02 00:44:29]

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/api.py:426:
f.result.presentation.status = self.m.step.FAILURE
On 2016/08/01 at 23:29:21, jbudorick wrote:
> Will this turn the step red rather than purple?

yes

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipes/andro...
File
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
(left):

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json:501:
"@@@STEP_LOG_LINE@Failure A@Failure A@@@",
Are you sure you want these failure logs going away?

[rnephew (Reviews Here), 2016-08-02 01:03:49]

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/api.py:426:
f.result.presentation.status = self.m.step.FAILURE
On 2016/08/02 00:44:29, martiniss wrote:
> On 2016/08/01 at 23:29:21, jbudorick wrote:
> > Will this turn the step red rather than purple?
> 
> yes

c/p the wrong line. Fixed.

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipes/andro...
File
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
(left):

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json:501:
"@@@STEP_LOG_LINE@Failure A@Failure A@@@",
On 2016/08/02 00:44:29, martiniss wrote:
> Are you sure you want these failure logs going away?

Yeah,there should be no failure detected on this one. It was an error that it
was there to begin with. I changed the test data to more accurately reflect
reality.

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipes/andro...
File scripts/slave/recipes/android/perf.expected/host_info_failure.json (right):

https://codereview.chromium.org/2204643002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/perf.expected/host_info_failure.json:503:
"@@@STEP_LOG_END@Failure A@@@",
This is the only one where a failure should have been detected, but it wasn't
before.

[rnephew (Reviews Here), 2016-08-02 01:05:26]

Patchset #2 (id:20001) has been deleted

[martiniss, 2016-08-02 01:12:08]

lgtm

[jbudorick, 2016-08-02 14:22:35]

lgtm

[rnephew (Reviews Here), 2016-08-02 14:22:49]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2016-08-02 14:22:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 14:27:22]

Description was changed from

==========
[Android] Add failures to results log line for Host Info step.

BUG=592140
==========

to

==========
[Android] Add failures to results log line for Host Info step.

BUG=592140

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/18ec037fcdf5072a4d16...
==========

[commit-bot: I haz the power, 2016-08-02 14:27:23]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/18ec037fcdf5072a4d16...