Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2204643002: [Android] Add failures to results log line for Host Info step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: [Android] Add failures to results log line for Host Info step. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index b7c5c9ac41b76f69e19c5d1026d2b025c2c688a1..c536fcc0f05e9164e58f2075abf99452f52649f5 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -383,7 +383,7 @@ class AndroidApi(recipe_api.RecipeApi):
infra_step=True,
step_test_data=lambda: self.m.json.test_api.output({
'valid': True,
- 'failures': ['Failure A', 'Failure B'],
+ 'failures': [],
'_host_info': {
'os_system': 'os_system',
'os_release': 'os_release',
@@ -420,12 +420,10 @@ class AndroidApi(recipe_api.RecipeApi):
}}),
**kwargs)
return results
- except self.m.step.InfraFailure:
- pass
- finally:
- if results:
- for failure in results.json.output.get('failures', []):
- results.presentation.logs[failure] = [failure]
+ except self.m.step.InfraFailure as f:
+ for failure in f.result.json.output.get('failures', []):
+ f.result.presentation.logs[failure] = [failure]
+ f.result.presentation.status = self.m.step.EXCEPTION
def device_recovery(self, restart_usb=False, **kwargs):
args = [
« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698