third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp - Issue 2204503002: ResizeObserver pt6: integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 2204503002: ResizeObserver pt6: integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for moving dom inside eventloop Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

index 1e62ca9fcd732c047ec41330e5413b32b2ead2ca..4e0d1aee665f032a4893bfa54ddbabe34c182dd3 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

@@ -166,6 +166,8 @@ void LayoutSVGContainer::updateCachedBoundaries()

{

SVGLayoutSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m_objectBoundingBoxValid, m_strokeBoundingBox, m_paintInvalidationBoundingBox);

SVGLayoutSupport::intersectPaintInvalidationRectWithResources(this, m_paintInvalidationBoundingBox);

+ if (element())

+ element()->sizeMayHaveChanged();

esprehn 2016/08/10 04:27:09 I assume you have tests for all of these callers?

atotic1 2016/08/10 18:25:33 Yes, a whole new test file: svg.html

}

bool LayoutSVGContainer::nodeAtFloatPoint(HitTestResult& result, const FloatPoint& pointInParent, HitTestAction hitTestAction)