Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 2204503002: ResizeObserver pt6: integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test for moving dom inside eventloop Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 159
160 void LayoutSVGContainer::addOutlineRects(Vector<LayoutRect>& rects, const Layout Point&, IncludeBlockVisualOverflowOrNot) const 160 void LayoutSVGContainer::addOutlineRects(Vector<LayoutRect>& rects, const Layout Point&, IncludeBlockVisualOverflowOrNot) const
161 { 161 {
162 rects.append(LayoutRect(paintInvalidationRectInLocalSVGCoordinates())); 162 rects.append(LayoutRect(paintInvalidationRectInLocalSVGCoordinates()));
163 } 163 }
164 164
165 void LayoutSVGContainer::updateCachedBoundaries() 165 void LayoutSVGContainer::updateCachedBoundaries()
166 { 166 {
167 SVGLayoutSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m _objectBoundingBoxValid, m_strokeBoundingBox, m_paintInvalidationBoundingBox); 167 SVGLayoutSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m _objectBoundingBoxValid, m_strokeBoundingBox, m_paintInvalidationBoundingBox);
168 SVGLayoutSupport::intersectPaintInvalidationRectWithResources(this, m_paintI nvalidationBoundingBox); 168 SVGLayoutSupport::intersectPaintInvalidationRectWithResources(this, m_paintI nvalidationBoundingBox);
169 if (element())
170 element()->sizeMayHaveChanged();
esprehn 2016/08/10 04:27:09 I assume you have tests for all of these callers?
atotic1 2016/08/10 18:25:33 Yes, a whole new test file: svg.html
169 } 171 }
170 172
171 bool LayoutSVGContainer::nodeAtFloatPoint(HitTestResult& result, const FloatPoin t& pointInParent, HitTestAction hitTestAction) 173 bool LayoutSVGContainer::nodeAtFloatPoint(HitTestResult& result, const FloatPoin t& pointInParent, HitTestAction hitTestAction)
172 { 174 {
173 // Give LayoutSVGViewportContainer a chance to apply its viewport clip 175 // Give LayoutSVGViewportContainer a chance to apply its viewport clip
174 if (!pointIsInsideViewportClip(pointInParent)) 176 if (!pointIsInsideViewportClip(pointInParent))
175 return false; 177 return false;
176 178
177 FloatPoint localPoint; 179 FloatPoint localPoint;
178 if (!SVGLayoutSupport::transformToUserSpaceAndCheckClipping(this, localToSVG ParentTransform(), pointInParent, localPoint)) 180 if (!SVGLayoutSupport::transformToUserSpaceAndCheckClipping(this, localToSVG ParentTransform(), pointInParent, localPoint))
(...skipping 21 matching lines...) Expand all
200 // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispat ched." 202 // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispat ched."
201 return false; 203 return false;
202 } 204 }
203 205
204 SVGTransformChange LayoutSVGContainer::calculateLocalTransform() 206 SVGTransformChange LayoutSVGContainer::calculateLocalTransform()
205 { 207 {
206 return SVGTransformChange::None; 208 return SVGTransformChange::None;
207 } 209 }
208 210
209 } // namespace blink 211 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698