Add UI to new botlist to show summary

Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list
looks more mangled than it actually is.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/e448e8ec16dfdb9c7e7639791a89b492707e6b44

[kjlubick, 2016-08-01 19:56:22]

Description was changed from

==========
Add UI to new botlist to show summary

BUG=631047
==========

to

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

BUG=631047
==========

[kjlubick, 2016-08-01 20:04:38]

Description was changed from

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

BUG=631047
==========

to

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list looks
more mangled than it actually is.

BUG=631047
==========

[kjlubick, 2016-08-01 20:05:50]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-01 20:05:51]

It is currently live at
https://2239-7c258a4-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newu...

Since the staging data isn't all that interesting, I've loaded in some mock data
at
https://goto.google.com/sivef

Summary screenshot:
https://screenshot.googleplex.com/5C9DA8Y076F

Login screenshot:
https://screenshot.googleplex.com/4bO5ND7ZzFH

[kjlubick, 2016-08-01 20:06:26]

Description was changed from

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list looks
more mangled than it actually is.

BUG=631047
==========

to

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list
looks more mangled than it actually is.

BUG=631047
==========

[jcgregorio, 2016-08-02 12:19:06]

On 2016/08/01 at 20:05:51, kjlubick wrote:
> It is currently live at
>
https://2239-7c258a4-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newu...
> 
> Since the staging data isn't all that interesting, I've loaded in some mock
data at
> https://goto.google.com/sivef
> 
> Summary screenshot:
> https://screenshot.googleplex.com/5C9DA8Y076F
> 
> Login screenshot:
> https://screenshot.googleplex.com/4bO5ND7ZzFH

Needs more whitespace at the following points.

  https://screenshot.googleplex.com/VrvDkeR65ZS.png

Also, make the bot list a table, right justify the names, "Bots Alive", and left
justify the values, "2625".

[stephana, 2016-08-02 14:00:29]

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:118: <thead
on-sort_change="sortChange">
There should be a <tr> element wrapping the <th> elements.

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:318: filter: {
If these are exposed properties then they should be documented up top, otherwise
they should be prefixed with "_".

[kjlubick, 2016-08-03 12:52:30]

https://screenshot.googleplex.com/4dbQbihm1EO

More whitespace added, summary is now a table.

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:118: <thead
on-sort_change="sortChange">
On 2016/08/02 at 14:00:29, stephana wrote:
> There should be a <tr> element wrapping the <th> elements.

Done.

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:318: filter: {
On 2016/08/02 at 14:00:29, stephana wrote:
> If these are exposed properties then they should be documented up top,
otherwise they should be prefixed with "_".

Done.

[jcgregorio, 2016-08-03 13:00:56]

On 2016/08/03 at 12:52:41, kjlubick wrote:
> 

https://screenshot.googleplex.com/L6U8YorOVXd.png

"Bots" should be able to be removed from all the botlist entries.

Consider renaming "Currently Showing" to "Displayed"

[kjlubick, 2016-08-03 13:07:28]

On 2016/08/03 at 13:00:56, jcgregorio wrote:
> On 2016/08/03 at 12:52:41, kjlubick wrote:
> > 
> 
> https://screenshot.googleplex.com/L6U8YorOVXd.png
> 
> "Bots" should be able to be removed from all the botlist entries.
> 
> Consider renaming "Currently Showing" to "Displayed"

Done.

[jcgregorio, 2016-08-03 13:11:51]

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list-summary.html (right):

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list-summary.html:51: <!--
TODO(kjlubick) Once url params have been implemented, have these
Yeah, look at
https://github.com/google/skia-buildbot/blob/master/res/js/common.js#L571 for
mirroring state to/from the URL.

https://codereview.chromium.org/2204483002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list-summary.html (right):

https://codereview.chromium.org/2204483002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list-summary.html:15:
filtered_bots: Array<Object>, The bot list that is currently being shown
Describe the shape of Object, or point to a description of what's passed in.

[kjlubick, 2016-08-03 14:23:20]

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list-summary.html (right):

https://codereview.chromium.org/2204483002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list-summary.html:51: <!--
TODO(kjlubick) Once url params have been implemented, have these
On 2016/08/03 at 13:11:50, jcgregorio wrote:
> Yeah, look at
https://github.com/google/skia-buildbot/blob/master/res/js/common.js#L571 for
mirroring state to/from the URL.

Acknowledged.  I also like
https://github.com/google/skia-buildbot/blob/master/res/imp/url-params-sk.html

https://codereview.chromium.org/2204483002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list-summary.html (right):

https://codereview.chromium.org/2204483002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list-summary.html:15:
filtered_bots: Array<Object>, The bot list that is currently being shown
On 2016/08/03 at 13:11:51, jcgregorio wrote:
> Describe the shape of Object, or point to a description of what's passed in.

Done.  In bot-list-data.

[jcgregorio, 2016-08-03 14:30:08]

lgtm

[kjlubick, 2016-08-03 14:31:25]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-08-03 14:31:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 14:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 14:31:30]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-08-03 14:31:45]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-03 14:31:46]

lgtm

[KevinL, 2016-08-03 14:31:51]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-08-03 14:31:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 14:35:16]

Description was changed from

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list
looks more mangled than it actually is.

BUG=631047
==========

to

==========
Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list
looks more mangled than it actually is.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/e448e8ec16dfdb9c7e7639791a89b492707e6b44
==========

[commit-bot: I haz the power, 2016-08-03 14:35:17]

Committed patchset #7 (id:120001) as
https://github.com/luci/luci-py/commit/e448e8ec16dfdb9c7e7639791a89b492707e6b44