Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: appengine/swarming/elements/res/imp/botlist/bot-filters.html

Issue 2204483002: Add UI to new botlist to show summary (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@bot-summary-api
Patch Set: Add docs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/elements/package.json ('k') | appengine/swarming/elements/res/imp/botlist/bot-list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/elements/res/imp/botlist/bot-filters.html
diff --git a/appengine/swarming/elements/res/imp/botlist/bot-filters.html b/appengine/swarming/elements/res/imp/botlist/bot-filters.html
index b1f2648df7c9802a1a41712faa4ee1183a7117f6..2f066f9d3b25f8842fe61a59f4fe1e938b36beb4 100644
--- a/appengine/swarming/elements/res/imp/botlist/bot-filters.html
+++ b/appengine/swarming/elements/res/imp/botlist/bot-filters.html
@@ -441,25 +441,23 @@
arr.push(param);
filterGroups[primary] = arr;
});
- return {
- filter: function(bot){
- var retVal = true;
- // Look up all the primary keys we are filter by, then look up how
- // to filter (in filterMap) and apply the filter for each filter
- // option.
- for (primary in filterGroups){
- var params = filterGroups[primary];
- var filter = filterMap[primary];
- var groupResult = false;
- if (filter) {
- params.forEach(function(param){
- groupResult = groupResult || filter.bind(this)(bot,param);
- }.bind(this));
- }
- retVal = retVal && groupResult;
+ return function(bot){
+ var retVal = true;
+ // Look up all the primary keys we are filter by, then look up how
+ // to filter (in filterMap) and apply the filter for each filter
+ // option.
+ for (primary in filterGroups){
+ var params = filterGroups[primary];
+ var filter = filterMap[primary];
+ var groupResult = false;
+ if (filter) {
+ params.forEach(function(param){
+ groupResult = groupResult || filter.bind(this)(bot,param);
+ }.bind(this));
}
- return retVal;
+ retVal = retVal && groupResult;
}
+ return retVal;
}
},
« no previous file with comments | « appengine/swarming/elements/package.json ('k') | appengine/swarming/elements/res/imp/botlist/bot-list.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698