[Extensions] Remove SyncIOThreadExtensionFunction

[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140
Committed: https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1
Cr-Commit-Position: refs/heads/master@{#409807}

[Devlin, 2016-08-03 21:34:19]

Description was changed from

==========
[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=
==========

to

==========
[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140
==========

[Devlin, 2016-08-03 21:37:30]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 21:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 22:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:39:20]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-03 22:40:30]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-08-03 22:41:12]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-08-03 23:10:37]

lgtm

https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api.h (right):

https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api.h:516: void OnError(
this can/should be private:

[Devlin, 2016-08-03 23:13:38]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 23:14:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 00:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 00:32:28]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-04 16:32:43]

https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api.h (right):

https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api.h:516: void OnError(
On 2016/08/03 23:10:37, lazyboy wrote:
> this can/should be private:

Done.

[Devlin, 2016-08-04 16:32:46]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-08-04 16:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2204363002/#ps40001
(title: "lazyboy@'s")

[commit-bot: I haz the power, 2016-08-04 16:33:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 16:38:26]

Description was changed from

==========
[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140
==========

to

==========
[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140
==========

[commit-bot: I haz the power, 2016-08-04 16:38:28]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-04 16:41:03]

Description was changed from

==========
[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140
==========

to

==========
[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140

Committed: https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1
Cr-Commit-Position: refs/heads/master@{#409807}
==========

[commit-bot: I haz the power, 2016-08-04 16:41:04]

Patchset 2 (id:??) landed as
https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1
Cr-Commit-Position: refs/heads/master@{#409807}