Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2204363002: [Extensions] Remove SyncIOThreadExtensionFunction (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove SyncIOThreadExtensionFunction ExtensionFunction has umpteen different implementations, when really there should only be handful (maybe just UIThread and IOThread variants). Remove one of them to start making a dent. BUG=634140 Committed: https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1 Cr-Commit-Position: refs/heads/master@{#409807}

Patch Set 1 : ; #

Total comments: 2

Patch Set 2 : lazyboy@'s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -93 lines) Patch
M extensions/browser/api/web_request/web_request_api.h View 1 4 chunks +9 lines, -10 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 12 chunks +27 lines, -40 lines 0 comments Download
M extensions/browser/extension_function.h View 1 chunk +0 lines, -26 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Devlin
4 years, 4 months ago (2016-08-03 22:41:13 UTC) #8
lazyboy
lgtm https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/web_request/web_request_api.h File extensions/browser/api/web_request/web_request_api.h (right): https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/web_request/web_request_api.h#newcode516 extensions/browser/api/web_request/web_request_api.h:516: void OnError( this can/should be private:
4 years, 4 months ago (2016-08-03 23:10:37 UTC) #9
Devlin
https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/web_request/web_request_api.h File extensions/browser/api/web_request/web_request_api.h (right): https://codereview.chromium.org/2204363002/diff/20001/extensions/browser/api/web_request/web_request_api.h#newcode516 extensions/browser/api/web_request/web_request_api.h:516: void OnError( On 2016/08/03 23:10:37, lazyboy wrote: > this ...
4 years, 4 months ago (2016-08-04 16:32:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204363002/40001
4 years, 4 months ago (2016-08-04 16:33:25 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-04 16:38:28 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 16:41:04 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1
Cr-Commit-Position: refs/heads/master@{#409807}

Powered by Google App Engine
This is Rietveld 408576698