[Extensions] Remove SyncIOThreadExtensionFunction

extensions/browser/api/web_request/web_request_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_H_
 #define EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_H_
 
 #include <stdint.h>
 
 #include <list>
@@ skipping 458 matching lines @@
   // respective rules registry.
   std::map<RulesRegistryKey,
       scoped_refptr<extensions::WebRequestRulesRegistry> > rules_registries_;
 
   std::unique_ptr<extensions::WebRequestEventRouterDelegate>
       web_request_event_router_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionWebRequestEventRouter);
 };
 
-class WebRequestInternalFunction : public SyncIOThreadExtensionFunction {
+class WebRequestInternalFunction : public IOThreadExtensionFunction {
  public:
   WebRequestInternalFunction() {}
 
  protected:
   ~WebRequestInternalFunction() override {}
 
   const std::string& extension_id_safe() const {
     return extension() ? extension_id() : base::EmptyString();
   }
 };
 
 class WebRequestInternalAddEventListenerFunction
     : public WebRequestInternalFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webRequestInternal.addEventListener",
                              WEBREQUESTINTERNAL_ADDEVENTLISTENER)
 
  protected:
   ~WebRequestInternalAddEventListenerFunction() override {}
 
   // ExtensionFunction:
-  bool RunSync() override;
+  ResponseAction Run() override;
 };
 
 class WebRequestInternalEventHandledFunction
     : public WebRequestInternalFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webRequestInternal.eventHandled",
                              WEBREQUESTINTERNAL_EVENTHANDLED)
 
  protected:
   ~WebRequestInternalEventHandledFunction() override {}
 
-  // Unblocks the network request and sets |error_| such that the developer
-  // console will show the respective error message. Use this function to handle
-  // incorrect requests from the extension that cannot be detected by the schema
+  // Unblocks the network request. Use this function when handling incorrect
+  // requests from the extension that cannot be detected by the schema
   // validator.
-  void RespondWithError(
+  void OnError(

[lazyboy, 2016/08/03 23:10:37]

this can/should be private:

[Devlin, 2016/08/04 16:32:42]

Done.

       const std::string& event_name,
       const std::string& sub_event_name,
       uint64_t request_id,
-      std::unique_ptr<ExtensionWebRequestEventRouter::EventResponse> response,
-      const std::string& error);
+      std::unique_ptr<ExtensionWebRequestEventRouter::EventResponse> response);
 
   // ExtensionFunction:
-  bool RunSync() override;
+  ResponseAction Run() override;
 };
 
 class WebRequestHandlerBehaviorChangedFunction
     : public WebRequestInternalFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webRequest.handlerBehaviorChanged",
                              WEBREQUEST_HANDLERBEHAVIORCHANGED)
 
  protected:
   ~WebRequestHandlerBehaviorChangedFunction() override {}
 
   // ExtensionFunction:
   void GetQuotaLimitHeuristics(
       extensions::QuotaLimitHeuristics* heuristics) const override;
   // Handle quota exceeded gracefully: Only warn the user but still execute the
   // function.
   void OnQuotaExceeded(const std::string& error) override;
-  bool RunSync() override;
+  ResponseAction Run() override;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_H_