Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2204343004: Revert of Expand scope of enable_hotwording. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expand scope of enable_hotwording. (patchset #5 id:80001 of https://codereview.chromium.org/2209843002/ ) Reason for revert: Broke official CrOS build. Original issue's description: > Expand scope of enable_hotwording. > > It is currently only in chrome/browser/BUILD.gn even though it is used > elsewhere. Moving it to chrome/common/features.gni and checking for it > where it is used. > > BUG=634044 > > Committed: https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88 > Cr-Commit-Position: refs/heads/master@{#409651} TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634044 Committed: https://crrev.com/60c1473ba214cff9ee701d5ea55b0c6025b582a7 Cr-Commit-Position: refs/heads/master@{#409681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -98 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 5 chunks +78 lines, -83 lines 0 comments Download
M chrome/common/features.gni View 2 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
Created Revert of Expand scope of enable_hotwording.
4 years, 4 months ago (2016-08-04 00:18:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204343004/1
4 years, 4 months ago (2016-08-04 00:19:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 00:20:39 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/60c1473ba214cff9ee701d5ea55b0c6025b582a7 Cr-Commit-Position: refs/heads/master@{#409681}
4 years, 4 months ago (2016-08-04 00:22:39 UTC) #6
Dirk Pranke
4 years, 4 months ago (2016-08-04 00:24:49 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698