Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/common/features.gni

Issue 2204343004: Revert of Expand scope of enable_hotwording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/features.gni
diff --git a/chrome/common/features.gni b/chrome/common/features.gni
index fd7245c24c9b2c7b5cecd8e30d77798e5a0e6bda..a74efab01e95ef0456cf40ddc40ee8e0d83180cf 100644
--- a/chrome/common/features.gni
+++ b/chrome/common/features.gni
@@ -5,16 +5,22 @@
# This is the GN version of //chrome/chrome_features.gypi.
# Please keep in sync!
-import("//build/config/chrome_build.gni")
import("//build/config/chromecast_build.gni")
-# Please keep features in alphabetical order.
declare_args() {
+ # Google Now is disabled to prepare for its removal.
+ # http://crbug.com/539674
+ enable_google_now = false
+
# Whether the Java UI is being used (Java infobars and popups, Java native
# settings and first run experience, sign-in etc.).
# Default to true if compiling for android, but allow this being overriden
# through the environment.
android_java_ui = is_android
+
+ # Use vulcanized HTML/CSS/JS resources to speed up WebUI (chrome://)
+ # pages. https://github.com/polymer/vulcanize
+ use_vulcanize = true
# Enables support for background apps.
enable_background = !is_ios && !is_android && !is_chromecast
@@ -22,25 +28,12 @@
enable_one_click_signin =
is_win || is_mac || (is_linux && !is_chromeos && !is_chromecast)
- # Google Now is disabled to prepare for its removal.
- # http://crbug.com/539674
- enable_google_now = false
-
- # 'Ok Google' hotwording is disabled by default. Set to true to enable. (This
- # will download a closed-source NaCl module at startup.) Chrome-branded
- # ChromeOS builds have this enabled by default.
- enable_hotwording = is_chrome_branded && is_chromeos
-
# Set to true to bundle all the mash related mojo services into chrome.
# Specify --mash to chrome to have chrome start the mash environment.
enable_package_mash_services = is_chromeos
# Enables vr shell.
enable_vr_shell = false
-
- # Use vulcanized HTML/CSS/JS resources to speed up WebUI (chrome://)
- # pages. https://github.com/polymer/vulcanize
- use_vulcanize = true
}
chrome_grit_defines = [
« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698