Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2204303003: DevTools: encapsulate extensible tabbed widget into the view manager. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: encapsulate extensible tabbed widget into the view manager. BUG=634145 Committed: https://crrev.com/ea28e728dc82bfda6c47cbee255e1affb96145c3 Cr-Commit-Position: refs/heads/master@{#409684}

Patch Set 1 #

Patch Set 2 : rebaselined #

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 4 months ago (2016-08-03 22:05:16 UTC) #2
dgozman
lgtm, but I skipped most of the code in TabbedLocation, since it should've been moved ...
4 years, 4 months ago (2016-08-03 22:30:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204303003/20001
4 years, 4 months ago (2016-08-03 23:13:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 00:38:38 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 00:40:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea28e728dc82bfda6c47cbee255e1affb96145c3
Cr-Commit-Position: refs/heads/master@{#409684}

Powered by Google App Engine
This is Rietveld 408576698