Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

Issue 2204303003: DevTools: encapsulate extensible tabbed widget into the view manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
index cbdd0a2ca5676dd5a3bde21f8dadf35bc1113c19..87f968c4adf612d20acd4442239ed99b2cab6d9b 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
@@ -47,15 +47,15 @@ WebInspector.InspectorView = function()
this._drawerSplitWidget.show(this.element);
// Create drawer tabbed pane.
- this._drawerTabbedPane = new WebInspector.ExtensibleTabbedPane("drawer-view", true);
+ this._drawerTabbedLocation = WebInspector.viewManager.createTabbedLocation("drawer-view", true, true);
+ this._drawerTabbedPane = this._drawerTabbedLocation.tabbedPane();
this._drawerTabbedPane.setMinimumSize(0, 27);
- this._drawerTabbedPane.enableMoreTabsButton();
var drawerToolbar = new WebInspector.Toolbar("drawer-close-toolbar");
var closeDrawerButton = new WebInspector.ToolbarButton(WebInspector.UIString("Close drawer"), "delete-toolbar-item");
closeDrawerButton.addEventListener("click", this.closeDrawer.bind(this));
drawerToolbar.appendToolbarItem(closeDrawerButton);
- this._drawerTabbedPane.tabbedPane().appendAfterTabStrip(drawerToolbar.element);
- this._drawerSplitWidget.installResizer(this._drawerTabbedPane.tabbedPane().headerElement());
+ this._drawerTabbedPane.appendAfterTabStrip(drawerToolbar.element);
+ this._drawerSplitWidget.installResizer(this._drawerTabbedPane.headerElement());
this._drawerSplitWidget.setSidebarWidget(this._drawerTabbedPane);
// Create main area tabbed pane.
@@ -123,10 +123,10 @@ WebInspector.InspectorView.prototype = {
* @param {string} locationName
* @return {?WebInspector.ViewLocation}
*/
- resolveLocation: function(locationName)
+ revealLocation: function(locationName)
{
this.showDrawer();
- return this._drawerTabbedPane;
+ return this._drawerTabbedLocation;
},
_loadPanelDesciptors: function()

Powered by Google App Engine
This is Rietveld 408576698