Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2204153003: Update pdfium/annots/annotation_squiggly_expected.pdf.0.png with actual squiggly annotation. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update pdfium/annots/annotation_squiggly_expected.pdf.0.png with actual squiggly annotation. Also, add a test case for squiggly annotation with opacity and longer length of squiggly annotation. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/a89e4fbd6b38d7551f3f6369d5776be90cfe5e49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M pdfium/annots/annotation_squiggly_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_squiggly_opacity.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_squiggly_opacity_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
jaepark
This is an updated test result + an additional test case for squiggly annotation (https://codereview.chromium.org/2206773004).
4 years, 4 months ago (2016-08-03 19:14:40 UTC) #2
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-03 19:33:13 UTC) #3
jaepark
4 years, 4 months ago (2016-08-03 20:34:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a89e4fbd6b38d7551f3f6369d5776be90cfe5e49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698