Generate default AP stream for squiggly annotation.

Generate default AP stream for squiggly annotation.

This patch generates a default AP stream for squiggly annotation so that
squiggly annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to a89e4fb to test squiggly annotations.

BUG=62625
Committed: https://pdfium.googlesource.com/pdfium/+/96a07863120273c8b89cba0e7d53ef29ae56d580

[jaepark, 2016-08-03 19:14:27]

jaepark@google.com changed reviewers:
+ thestig@chromium.org

[jaepark, 2016-08-03 19:14:28]

Need testing after landing https://codereview.chromium.org/2204153003/ .

[Lei Zhang, 2016-08-03 19:36:04]

lgtm with the DEPS update

https://codereview.chromium.org/2206773004/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2206773004/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:653: if (isUpwards)
Since it fits on 1 line:

sAppStream << fX << " " << isUpwards ? fTop : fBottom << " l ";

[jaepark, 2016-08-03 20:36:00]

Description was changed from

==========
Generate default AP stream for squiggly annotation.

This patch generates a default AP stream for squiggly annotation so that
squiggly annotations without AP stream can be displayed.

BUG=62625
==========

to

==========
Generate default AP stream for squiggly annotation.

This patch generates a default AP stream for squiggly annotation so that
squiggly annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to a89e4fb to test squiggly annotations.

BUG=62625
==========

[jaepark, 2016-08-03 20:41:41]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 20:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:44:36]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[jaepark, 2016-08-03 20:47:31]

Patchset #2 (id:20001) has been deleted

[jaepark, 2016-08-03 20:47:36]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:47:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaepark, 2016-08-03 20:55:40]

The CQ bit was unchecked by jaepark@google.com

[jaepark, 2016-08-03 20:55:49]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:14:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:14:11]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-03 21:16:29]

Rolled DEPs.

https://codereview.chromium.org/2206773004/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2206773004/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:653: if (isUpwards)
On 2016/08/03 19:36:04, Lei Zhang wrote:
> Since it fits on 1 line:
> 
> sAppStream << fX << " " << isUpwards ? fTop : fBottom << " l ";

Done.

[jaepark, 2016-08-03 21:16:48]

The CQ bit was checked by jaepark@google.com

[jaepark, 2016-08-03 21:16:48]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2206773004/#ps40001
(title: "Generate default AP stream for squiggly annotation.")

[commit-bot: I haz the power, 2016-08-03 21:16:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:17:04]

Description was changed from

==========
Generate default AP stream for squiggly annotation.

This patch generates a default AP stream for squiggly annotation so that
squiggly annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to a89e4fb to test squiggly annotations.

BUG=62625
==========

to

==========
Generate default AP stream for squiggly annotation.

This patch generates a default AP stream for squiggly annotation so that
squiggly annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to a89e4fb to test squiggly annotations.

BUG=62625

Committed:
https://pdfium.googlesource.com/pdfium/+/96a07863120273c8b89cba0e7d53ef29ae56...
==========

[commit-bot: I haz the power, 2016-08-03 21:17:05]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/96a07863120273c8b89cba0e7d53ef29ae56...