Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2204113002: Prevent hiding a toast during animation

Created:
4 years, 4 months ago by yoshiki
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Prevent hiding a toast during animation This patch should fix the crash (b/29503765). BUG=628511 BUG=b:29503765 TEST=show a toast and click dismiss button 20 times, no crash observed R=oshima@chromium.org TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2150603003 Cr-Commit-Position: refs/heads/master@{#406482} (cherry picked from commit 0444c447e813e8fb5931bb0cd141f8f2168ed392)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M ash/system/toast/toast_manager_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ash/system/toast/toast_overlay.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
yoshiki
Description was changed from ========== Prevent hiding a toast during animation This patch should fix ...
4 years, 4 months ago (2016-08-16 16:24:45 UTC) #1
yoshiki
4 years, 4 months ago (2016-08-16 16:24:45 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698