Prevent hiding a toast during animation

Prevent hiding a toast during animation

This patch should fix the crash (b/29503765).

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
R=oshima@chromium.org
TBR=stevenjb@chromium.org

Committed: https://crrev.com/0444c447e813e8fb5931bb0cd141f8f2168ed392
Cr-Commit-Position: refs/heads/master@{#406482}

[yoshiki, 2016-07-14 06:55:53]

Description was changed from

==========
.

BUG=
==========

to

==========
Prevent hiding a toast during animation

It may cause the crash (b/29503765).

BUG=b:29503765
TEST=none
==========

[yoshiki, 2016-07-14 06:55:53]

yoshiki@chromium.org changed reviewers:
+ oshima@chromium.org

[yoshiki, 2016-07-14 06:56:33]

Description was changed from

==========
Prevent hiding a toast during animation

It may cause the crash (b/29503765).

BUG=b:29503765
TEST=none
==========

to

==========
Prevent hiding a toast during animation

This patch may fix the crash (b/29503765). 

BUG=b:29503765
TEST=none
==========

[yoshiki, 2016-07-14 07:05:15]

Description was changed from

==========
Prevent hiding a toast during animation

This patch may fix the crash (b/29503765). 

BUG=b:29503765
TEST=none
==========

to

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
==========

[yoshiki, 2016-07-14 07:05:51]

Oshima-san, PTAL

[oshima, 2016-07-14 13:18:32]

You probably should file a crbug for merge.

https://codereview.chromium.org/2150603003/diff/20001/ash/common/system/toast...
File ash/common/system/toast/toast_overlay.cc (right):

https://codereview.chromium.org/2150603003/diff/20001/ash/common/system/toast...
ash/common/system/toast/toast_overlay.cc:257: return;
won't his also prevent showing during hiding animation? Is it ok?

[yoshiki, 2016-07-15 02:38:31]

I'll file a crbug issue. Thanks.

https://codereview.chromium.org/2150603003/diff/20001/ash/common/system/toast...
File ash/common/system/toast/toast_overlay.cc (right):

https://codereview.chromium.org/2150603003/diff/20001/ash/common/system/toast...
ash/common/system/toast/toast_overlay.cc:257: return;
On 2016/07/14 13:18:31, oshima wrote:
> won't his also prevent showing during hiding animation? Is it ok?

It doesn't happen, since a toast overlay instance is not reused. The toast
manager instanciates new ToastOverlay after hiding animation of previous toast.

I added DCHECK.

[yoshiki, 2016-07-15 04:09:52]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 04:10:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 04:51:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:51:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[oshima_google, 2016-07-15 05:05:54]

oshima@google.com changed reviewers:
+ oshima@google.com

[oshima_google, 2016-07-15 05:05:54]

can you check test failures?

[yoshiki, 2016-07-15 06:06:49]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 06:07:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 06:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 06:38:28]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-07-15 07:08:09]

On 2016/07/15 05:05:54, oshima1 wrote:
> can you check test failures?

I fixed the test failure. PTAL.

[yoshiki, 2016-07-15 07:11:21]

Description was changed from

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
==========

to

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
==========

[oshima_google, 2016-07-15 14:26:29]

lgtm

[yoshiki, 2016-07-15 16:21:05]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2016-07-15 16:21:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 16:30:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 16:30:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoshiki, 2016-07-19 02:24:21]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:25:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:34:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoshiki, 2016-07-20 02:37:24]

Description was changed from

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
==========

to

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
R=oshima@chromium.org
TBR=stevenjb@chromium.org
==========

[yoshiki, 2016-07-20 02:37:50]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:38:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:24:12]

Description was changed from

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
R=oshima@chromium.org
TBR=stevenjb@chromium.org
==========

to

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
R=oshima@chromium.org
TBR=stevenjb@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 04:24:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-20 04:24:26]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 04:26:42]

Description was changed from

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765). 

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
R=oshima@chromium.org
TBR=stevenjb@chromium.org
==========

to

==========
Prevent hiding a toast during animation

This patch should fix the crash (b/29503765).

BUG=628511
BUG=b:29503765
TEST=show a toast and click dismiss button 20 times, no crash observed
R=oshima@chromium.org
TBR=stevenjb@chromium.org

Committed: https://crrev.com/0444c447e813e8fb5931bb0cd141f8f2168ed392
Cr-Commit-Position: refs/heads/master@{#406482}
==========

[commit-bot: I haz the power, 2016-07-20 04:26:43]

Patchset 5 (id:??) landed as
https://crrev.com/0444c447e813e8fb5931bb0cd141f8f2168ed392
Cr-Commit-Position: refs/heads/master@{#406482}