Issue 22041003: Introduce Push and Pop register macro instructions for all platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22041003: Introduce Push and Pop register macro instructions for all platforms (Closed)

Created:
7 years, 4 months ago by haitao.feng

Modified:
7 years, 4 months ago

Reviewers:
Paul Lind, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Introduce Push and Pop register macro instructions for all platforms R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16051

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -10 lines)			Patch
M	src/arm/macro-assembler-arm.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Addressed danno's comment at https://codereview.chromium.org/18014003/patch/51001/52010. It might make sense to use macro assembler instructions in ...

7 years, 4 months ago (2013-08-05 02:21:18 UTC) #1

Paul Lind

This looks fine for MIPS as written, but once landed, we may replace all push/pop ...

7 years, 4 months ago (2013-08-05 06:20:17 UTC) #2

haitao.feng

7 years, 4 months ago (2013-08-05 12:43:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16051 (presubmit successful).

Expand Messages | Collapse Messages