Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2204063002: Add configuration_changed event and set_background_opacity request. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add configuration_changed event and set_background_opacity request. * remote shell API version is updated to 9. * Send the current primary display info because primary display is dynamic and can change or even go away. * This also fixed a bug where a underlay wasn't created when it started maximized. BUG=632083 TEST=tested on new and old impl on android side. Updated unit test. Review-Url: https://codereview.chromium.org/2189073003 Cr-Commit-Position: refs/heads/master@{#409089} (cherry picked from commit 80d20b2f6bc5a6aa8e0caa37f517aef783d3186d) Review URL: https://codereview.chromium.org/2204063002 . Cr-Commit-Position: refs/branch-heads/2785@{#474} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -51 lines) Patch
M components/exo/shell_surface.h View 3 chunks +8 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 3 chunks +31 lines, -20 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 9 chunks +64 lines, -15 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 7 chunks +38 lines, -4 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 5 chunks +28 lines, -2 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 4 chunks +12 lines, -7 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 4 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 4 months ago (2016-08-03 00:51:58 UTC) #2
it's merged but git somehow failed to update CL. closing

Powered by Google App Engine
This is Rietveld 408576698