Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 220403006: Revert of Tighten up webrtc audio tests. (Closed)

Created:
6 years, 8 months ago by rlarocque
Modified:
6 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Tighten up webrtc audio tests. (https://codereview.chromium.org/216523003/) Reason for revert: This might have resulted in some flaky tests. This failure happened two builds after the patch landed. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10598 See bug for more details. BUG=358759 Original issue's description: > Tighten up webrtc audio tests. > > See http://goo.gl/LDae10. I'm trying to improve this algorithm. We used to > check that some value was high enough and that the average was in the right > ballpark. The new algorithm will count falling edges in the peaks instead, > as a means to detect the peaks in the audio signal. The algorithm reliably > yields one peak per second of sampled audio, which is correct because the > audio signal beeps at 1 Hz. To get some margin, I'm sampling four seconds > and checking that I get at least two peaks, which should be a rock solid > assumption even on slow machines. > > BUG=357287, 357626 > R=perkj@chromium.org > NOTRY=True > (passed all trybots, just got stuck on a broken win trybot) > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260878 TBR=perkj@chromium.org,phoglund@chromium.org NOTREECHECKS=true NOTRY=true BUG=357287, 357626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -29 lines) Patch
M content/test/data/media/peerconnection-call.html View 4 chunks +6 lines, -6 lines 0 comments Download
M content/test/data/media/webrtc_test_audio.js View 2 chunks +18 lines, -22 lines 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rlarocque
Created Revert of Tighten up webrtc audio tests.
6 years, 8 months ago (2014-04-01 19:05:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/220403006/1
6 years, 8 months ago (2014-04-01 19:05:45 UTC) #2
commit-bot: I haz the power
Change committed as 260913
6 years, 8 months ago (2014-04-01 19:07:09 UTC) #3
phoglund_chromium
6 years, 8 months ago (2014-04-02 08:31:40 UTC) #4
Message was sent while issue was closed.
On 2014/04/01 19:07:09, I haz the power (commit-bot) wrote:
> Change committed as 260913

This revert looks incorrect to me. You are referring to build 10598, but my
patch landed in 10599 on the same builder. Indeed, the flake you are seeing is
with the old code and is precisely what I tried to fix.

Powered by Google App Engine
This is Rietveld 408576698