DescriptionRevert of Tighten up webrtc audio tests. (https://codereview.chromium.org/216523003/)
Reason for revert:
This might have resulted in some flaky tests. This failure happened two builds after the patch landed.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10598
See bug for more details.
BUG=358759
Original issue's description:
> Tighten up webrtc audio tests.
>
> See http://goo.gl/LDae10. I'm trying to improve this algorithm. We used to
> check that some value was high enough and that the average was in the right
> ballpark. The new algorithm will count falling edges in the peaks instead,
> as a means to detect the peaks in the audio signal. The algorithm reliably
> yields one peak per second of sampled audio, which is correct because the
> audio signal beeps at 1 Hz. To get some margin, I'm sampling four seconds
> and checking that I get at least two peaks, which should be a rock solid
> assumption even on slow machines.
>
> BUG=357287, 357626
> R=perkj@chromium.org
> NOTRY=True
> (passed all trybots, just got stuck on a broken win trybot)
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260878
TBR=perkj@chromium.org,phoglund@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357287, 357626
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260913
Patch Set 1 #
Created: 6 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|