[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files it requires

[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
Committed: https://crrev.com/059a4c3e886ca394ac67703851d7e17022fedef5
Cr-Commit-Position: refs/heads/master@{#409448}

[Hzj_jie, 2016-08-02 23:24:09]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 23:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2016-08-02 23:24:50]

Description was changed from

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive target to depend on
the files it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

to

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive target to depend on
the files it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

[Hzj_jie, 2016-08-02 23:24:50]

zijiehe@chromium.org changed reviewers:
+ joedow@chromium.org

[Hzj_jie, 2016-08-03 00:11:02]

Description was changed from

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive target to depend on
the files it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

to

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files
it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

[commit-bot: I haz the power, 2016-08-03 01:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 01:06:25]

Dry run: This issue passed the CQ dry run.

[joedow1, 2016-08-03 01:19:24]

joedow@google.com changed reviewers:
+ joedow@google.com

[joedow1, 2016-08-03 01:19:24]

From the CL description it sounds like this is a short-term workaround.  If you
are getting traction with the GN team on the original issue, then I'm fine
waiting for a proper fix from them (or guidance on the correct long-term fix on
our side).

[Hzj_jie, 2016-08-03 01:34:43]

On 2016/08/03 01:19:24, joedow1 wrote:
> From the CL description it sounds like this is a short-term workaround.  If
you
> are getting traction with the GN team on the original issue, then I'm fine
> waiting for a proper fix from them (or guidance on the correct long-term fix
on
> our side).

Talked offline with Joe, this should be a temporary workaround, but we may need
it for a while. I have linked bug 632141 with 633650. And we can revert this
change once the later one has been fixed. I will also add comments in the
BUILD.gn file.

[Hzj_jie, 2016-08-03 01:37:22]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 01:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-08-03 01:42:01]

joedow@chromium.org changed reviewers:
- joedow@google.com

[joedow, 2016-08-03 01:42:02]

lgtm

[commit-bot: I haz the power, 2016-08-03 03:38:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 03:38:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hzj_jie, 2016-08-03 03:38:41]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-08-03 03:39:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 04:00:41]

Description was changed from

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files
it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

to

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files
it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

[commit-bot: I haz the power, 2016-08-03 04:00:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 04:02:29]

Description was changed from

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files
it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141
==========

to

==========
[Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files
it requires

In GN build, rebuilding certain package components does not regenerate
chromoting.msi. This is due to a GN build issue discribed in
http://crbug.com/633650. Before the issue has been correctly addressed, a
workaround is to actively add inputs to hint action target to depend on the
correct input files.

BUG=632141

Committed: https://crrev.com/059a4c3e886ca394ac67703851d7e17022fedef5
Cr-Commit-Position: refs/heads/master@{#409448}
==========

[commit-bot: I haz the power, 2016-08-03 04:02:30]

Patchset 2 (id:??) landed as
https://crrev.com/059a4c3e886ca394ac67703851d7e17022fedef5
Cr-Commit-Position: refs/heads/master@{#409448}