Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Unified Diff: remoting/host/BUILD.gn

Issue 2203783003: [Chromoting] [GN Build] Force remoting_host_me2me_archive to depend on the files it requires (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments to link to bug 633650 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/BUILD.gn
diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn
index 0100db9504067ef453de5ec03f1df1329aa7ce1d..ec20d8b59cacb549090de4312379feb8b033b94a 100644
--- a/remoting/host/BUILD.gn
+++ b/remoting/host/BUILD.gn
@@ -1217,21 +1217,26 @@ if (enable_me2me_host) {
_official_build = "0"
}
- _generated_files = rebase_path(
- [
- "$root_out_dir/remote_assistance_host.exe",
- "$root_out_dir/remote_security_key.exe",
- "$root_out_dir/remoting_core.dll",
- "$root_out_dir/remoting_desktop.exe",
- "$root_out_dir/remoting_host.exe",
- "$root_out_dir/remoting_native_messaging_host.exe",
- "$root_out_dir/remoting_start_host.exe",
- "$root_gen_dir/remoting/CREDITS.txt",
- "$root_out_dir/remoting/com.google.chrome.remote_assistance.json",
- "$root_out_dir/remoting/com.google.chrome.remote_desktop.json",
- "$root_out_dir/icudtl.dat",
- ],
- root_build_dir)
+ # Due to GN build issue http://crbug.com/633650, we need to actively set
+ # inputs parameter to tell GN to depend on these files. So change to each
+ # following files will trigger this target to be rebuilt.
+ # TODO(zijiehe): Remove inputs parameter once bug 633650 has been
+ # addressed.
+ inputs = [
+ "$root_out_dir/remote_assistance_host.exe",
+ "$root_out_dir/remote_security_key.exe",
+ "$root_out_dir/remoting_core.dll",
+ "$root_out_dir/remoting_desktop.exe",
+ "$root_out_dir/remoting_host.exe",
+ "$root_out_dir/remoting_native_messaging_host.exe",
+ "$root_out_dir/remoting_start_host.exe",
+ "$root_gen_dir/remoting/CREDITS.txt",
+ "$root_out_dir/remoting/com.google.chrome.remote_assistance.json",
+ "$root_out_dir/remoting/com.google.chrome.remote_desktop.json",
+ "$root_out_dir/icudtl.dat",
+ ]
+
+ _generated_files = rebase_path(inputs, root_build_dir)
_extra_files = []
args =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698