Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2203733005: Update pdfium/annots/annotation_strikeout_expected.pdf.0.png with actual strikeout annotation. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update pdfium/annots/annotation_strikeout_expected.pdf.0.png with actual strikeout annotation. Also, add a test case for strikeout annotation with opacity. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/ddc1938d718be26a64192cfabdbeb64792d58fb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M pdfium/annots/annotation_strikeout_expected.pdf.0.png View Binary file 0 comments Download
A + pdfium/annots/annotation_strikeout_opacity.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_strikeout_opacity_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
jaepark
This is an updated test result + an additional test case for strike out annotation ...
4 years, 4 months ago (2016-08-03 00:04:03 UTC) #2
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-03 00:09:25 UTC) #3
jaepark
4 years, 4 months ago (2016-08-03 00:10:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ddc1938d718be26a64192cfabdbeb64792d58fb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698