chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h ('K') | « chrome/installer/mac/app/NSError+ChromeInstallerAdditions.h ('k') | chrome/installer/mac/app/OmahaCommunication.h » ('j') | chrome/installer/mac/app/OmahaCommunication.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m

diff --git a/chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m b/chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m

index 4cb23edcbdbf20baab53be63afcd4063c8fbc110..701895dda98d96c3a5851f29c88be8b235d66863 100644

--- a/chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m

+++ b/chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m

@@ -5,8 +5,6 @@

#import "NSError+ChromeInstallerAdditions.h"

@implementation NSError (ChromeInstallerAdditions)

-// Creates a custom error object to be used as the popup alert that the user

-// will be shown.

+ (NSError*)errorForAlerts:(NSString*)message

withDescription:(NSString*)description

isRecoverable:(BOOL)recoverable {