Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3863)

Unified Diff: chrome/installer/mac/app/BUILD.gn

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved comments, made many minor changes, ready for review! Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/BUILD.gn
diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn
index d535005c3d4bf6bde656d2c302d2850a61bc8ae8..bba02d656b36dc12c86db905261b42558e46bbe5 100644
--- a/chrome/installer/mac/app/BUILD.gn
+++ b/chrome/installer/mac/app/BUILD.gn
@@ -14,7 +14,9 @@ source_set("mac_installer_base") {
"OmahaXMLParser.m",
"OmahaXMLRequest.m",
"SystemInfo.m",
+ "Unpacker.m",
]
+ configs += [ "//build/config/compiler:enable_arc" ]
Sidney San Martín 2016/08/19 22:06:04 \o/
Anna Zeng 2016/08/23 03:13:43 Acknowledged.
}
mac_app_bundle("mac_installer_app") {
@@ -32,8 +34,8 @@ mac_app_bundle("mac_installer_app") {
]
libs = [
- "AppKit.framework",
- "CoreFoundation.framework",
+ "Cocoa.framework",
+ "DiskArbitration.framework",
]
}
@@ -47,6 +49,7 @@ test("mac_installer_unittests") {
sources = [
"testing/OmahaXMLRequest_test.mm",
"testing/SystemInfo_test.mm",
+ "testing/Unpacker_test.mm",
]
deps = [
":mac_installer_base",
@@ -54,7 +57,10 @@ test("mac_installer_unittests") {
"//base/test:run_all_unittests",
"//testing/gtest:gtest",
]
- libs = [ "Foundation.framework" ]
+ libs = [
+ "Cocoa.framework",
+ "DiskArbitration.framework",
+ ]
data = [
"testing/requestCheck.dtd",
"testing/requestSample.xml",

Powered by Google App Engine
This is Rietveld 408576698