Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/installer/mac/app/Unpacker.h

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed all comments, rearranged app logic, rewrote test, a bit more error handling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/Unpacker.h
diff --git a/chrome/installer/mac/app/Unpacker.h b/chrome/installer/mac/app/Unpacker.h
new file mode 100644
index 0000000000000000000000000000000000000000..0dd8df5ae364b78198ee7acd6c650dbe20b96ad3
--- /dev/null
+++ b/chrome/installer/mac/app/Unpacker.h
@@ -0,0 +1,35 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_MAC_APP_UNPACKER_H_
+#define CHROME_INSTALLER_MAC_APP_UNPACKER_H_
+
+#import <Foundation/Foundation.h>
+
+@class Unpacker;
+@protocol UnpackDelegate
+- (void)unpacker:(Unpacker*)unpacker onSuccess:(NSString*)appPath;
+- (void)unpacker:(Unpacker*)unpacker onFailure:(NSError*)error;
+- (void)unpacker:(Unpacker*)unpacker onUnmountSuccess:(NSString*)mountpath;
+- (void)unpacker:(Unpacker*)unpacker onUnmountFailure:(NSError*)error;
+@optional
+- (void)unpacker:(Unpacker*)unpacker onMountSuccess:(NSString*)mountpath;
+- (void)unpacker:(Unpacker*)unpacker onMountFailure:(NSError*)error;
+@end
+
+@interface Unpacker : NSObject
+
+@property(nonatomic, assign) NSObject<UnpackDelegate>* delegate;
Sidney San Martín 2016/08/17 22:09:06 Instead of this, you can just declare your delegat
Sidney San Martín 2016/08/18 19:33:00 Just for posterity… I got the syntax wrong (by mi
Anna Zeng 2016/08/18 19:41:09 Done
+@property(nonatomic, copy) NSString* appPath;
+
+- (id)initWithFinalAppPath:(NSString*)appPath;
+
+// TODO: add a new "extractor" class to be nested into unpacker
+- (void)mountDMGFromURL:(NSURL*)fileURL;
+- (void)extractChrome;
+- (void)unmountDMG;
+
+@end
+
+#endif // CHROME_INSTALLER_MAC_APP_UNPACKER_H_

Powered by Google App Engine
This is Rietveld 408576698