chrome/installer/mac/app/OmahaXMLRequest.m - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/OmahaXMLRequest.m

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments, rearranged app logic, rewrote test, a bit more error handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/app/OmahaXMLRequest.m

diff --git a/chrome/installer/mac/app/OmahaXMLRequest.m b/chrome/installer/mac/app/OmahaXMLRequest.m

index 8ade57215c1fa275b7cd97df54dbdd31e22caa4f..b98dfe460e50e132b52c8eb1f3df9bdfb2497192 100644

--- a/chrome/installer/mac/app/OmahaXMLRequest.m

+++ b/chrome/installer/mac/app/OmahaXMLRequest.m

@@ -23,9 +23,7 @@

// user attributes that Omaha actually looks at. The other parameters are useful

// for logging purposes but otherwise not directly used.

+ (NSXMLDocument*)createXMLRequestBody {

- // TODO: might be a good idea in the future to add a version# for this

- // installer using [[NSBundle mainBundle]

- // objectForInfoDictionaryKey:@"CFBundleShortVersionString"]]

+ // TODO: not hard-code protocol version #?

NSString* protocol = @"3.0";

NSString* platform = @"mac";