Sketch SkPictureRecorder::optimizeFor(GrContext*).

Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002

Committed: https://skia.googlesource.com/skia/+/1bb5fecbea494d77d7d5633522be1cdc76d043ae

[mtklein_C, 2016-08-01 17:49:17]

Description was changed from

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

This depends on the not-yet-existing SkShader::optimizeFor(GrContext*),
or similiar.

BUG=skia:
==========

to

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

This depends on the not-yet-existing SkShader::optimizeFor(GrContext*),
or similiar.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002
==========

[mtklein_C, 2016-08-01 17:49:42]

Description was changed from

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

This depends on the not-yet-existing SkShader::optimizeFor(GrContext*),
or similiar.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002
==========

to

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

This depends on the not-yet-existing SkShader::optimizeFor(GrContext*),
or similiar.  Also depends on https://codereview.chromium.org/2197243003/.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002
==========

[mtklein_C, 2016-08-01 17:57:25]

mtklein@chromium.org changed reviewers:
+ djsollen@google.com, reed@google.com

[reed1, 2016-08-01 18:00:25]

lgtm

[mtklein_C, 2016-08-01 18:54:23]

Description was changed from

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

This depends on the not-yet-existing SkShader::optimizeFor(GrContext*),
or similiar.  Also depends on https://codereview.chromium.org/2197243003/.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002
==========

to

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002
==========

[mtklein_C, 2016-08-01 19:37:56]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 19:38:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:56:19]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-08-01 20:16:49]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-01 20:16:49]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2203453002/#ps40001
(title: "enough for demo")

[commit-bot: I haz the power, 2016-08-01 20:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:17:49]

Description was changed from

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002
==========

to

==========
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002

Committed:
https://skia.googlesource.com/skia/+/1bb5fecbea494d77d7d5633522be1cdc76d043ae
==========

[commit-bot: I haz the power, 2016-08-01 20:17:50]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1bb5fecbea494d77d7d5633522be1cdc76d043ae

[djsollen, 2016-08-02 12:37:56]

https://codereview.chromium.org/2203453002/diff/40001/src/core/SkPictureRecor...
File src/core/SkPictureRecorder.cpp (right):

https://codereview.chromium.org/2203453002/diff/40001/src/core/SkPictureRecor...
src/core/SkPictureRecorder.cpp:64: for (int i = 0; ctx && i < record->count();
i++) {
don't you want to avoid this loop if ctx == nullptr?

[mtklein, 2016-08-02 13:05:15]

On 2016/08/02 12:37:56, djsollen wrote:
>
https://codereview.chromium.org/2203453002/diff/40001/src/core/SkPictureRecor...
> File src/core/SkPictureRecorder.cpp (right):
> 
>
https://codereview.chromium.org/2203453002/diff/40001/src/core/SkPictureRecor...
> src/core/SkPictureRecorder.cpp:64: for (int i = 0; ctx && i < record->count();
> i++) {
> don't you want to avoid this loop if ctx == nullptr?

Yep.  Read it again?  Too subtle?

[djsollen, 2016-08-02 14:28:13]

On 2016/08/02 13:05:15, mtklein wrote:
> On 2016/08/02 12:37:56, djsollen wrote:
> >
>
https://codereview.chromium.org/2203453002/diff/40001/src/core/SkPictureRecor...
> > File src/core/SkPictureRecorder.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2203453002/diff/40001/src/core/SkPictureRecor...
> > src/core/SkPictureRecorder.cpp:64: for (int i = 0; ctx && i <
record->count();
> > i++) {
> > don't you want to avoid this loop if ctx == nullptr?
> 
> Yep.  Read it again?  Too subtle?

I just glanced at the for loop and didn't notice the double duty it was doing
until you pointed it out.