tools/perf/benchmarks/system_health.py - Issue 2203303002: [system-health] Re-enable non-verbose logging in System Health memory benchmarks

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2203303002: [system-health] Re-enable non-verbose logging in System Health memory benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/system_health.py

diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py

index a4f8dfb5aae17c5cc5c2212832cffa475312ea7e..0e289bc92b0d7c60508fbb9a061acafa8e6f2561 100644

--- a/tools/perf/benchmarks/system_health.py

+++ b/tools/perf/benchmarks/system_health.py

@@ -64,6 +64,9 @@ class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):

"""

def SetExtraBrowserOptions(self, options):

+ # TODO(petrcermak): Remove this and switch to log-on-retry

+ # (http://crbug.com/623058).

+ options.logging_verbosity = options.NON_VERBOSE_LOGGING

nednguyen 2016/08/03 12:31:13 Do we still crash failure that are not caught by c

petrcermak 2016/08/03 13:05:35 Actually, apart from the disabled smoke tests, we

nednguyen 2016/08/03 13:13:26 Yes. I hope the smoke tests would defend for all c

petrcermak 2016/08/03 13:16:40 Makes sense. In that case, let's abandon this patc

options.AppendExtraBrowserArgs([

# TODO(perezju): Temporary workaround to disable periodic memory dumps.

# See: http://crbug.com/513692

« no previous file with comments | « no previous file | tools/perf/benchmarks/system_health_smoke_test.py » ('j') | tools/perf/benchmarks/system_health_smoke_test.py » ('J')