Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2203303002: [system-health] Re-enable non-verbose logging in System Health memory benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 return 'system_health.key_mobile_sites' 57 return 'system_health.key_mobile_sites'
58 58
59 59
60 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark): 60 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
61 """Chrome Memory System Health Benchmark. 61 """Chrome Memory System Health Benchmark.
62 62
63 https://goo.gl/Jek2NL. 63 https://goo.gl/Jek2NL.
64 """ 64 """
65 65
66 def SetExtraBrowserOptions(self, options): 66 def SetExtraBrowserOptions(self, options):
67 # TODO(petrcermak): Remove this and switch to log-on-retry
68 # (http://crbug.com/623058).
69 options.logging_verbosity = options.NON_VERBOSE_LOGGING
nednguyen 2016/08/03 12:31:13 Do we still crash failure that are not caught by c
petrcermak 2016/08/03 13:05:35 Actually, apart from the disabled smoke tests, we
nednguyen 2016/08/03 13:13:26 Yes. I hope the smoke tests would defend for all c
petrcermak 2016/08/03 13:16:40 Makes sense. In that case, let's abandon this patc
67 options.AppendExtraBrowserArgs([ 70 options.AppendExtraBrowserArgs([
68 # TODO(perezju): Temporary workaround to disable periodic memory dumps. 71 # TODO(perezju): Temporary workaround to disable periodic memory dumps.
69 # See: http://crbug.com/513692 72 # See: http://crbug.com/513692
70 '--enable-memory-benchmarking', 73 '--enable-memory-benchmarking',
71 ]) 74 ])
72 75
73 def CreateTimelineBasedMeasurementOptions(self): 76 def CreateTimelineBasedMeasurementOptions(self):
74 options = timeline_based_measurement.Options( 77 options = timeline_based_measurement.Options(
75 chrome_trace_category_filter.ChromeTraceCategoryFilter( 78 chrome_trace_category_filter.ChromeTraceCategoryFilter(
76 '-*,disabled-by-default-memory-infra')) 79 '-*,disabled-by-default-memory-infra'))
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 options.config.atrace_config.app_name = 'org.chromium.webview_shell' 144 options.config.atrace_config.app_name = 'org.chromium.webview_shell'
142 return options 145 return options
143 146
144 @classmethod 147 @classmethod
145 def ShouldTearDownStateAfterEachStoryRun(cls): 148 def ShouldTearDownStateAfterEachStoryRun(cls):
146 return True 149 return True
147 150
148 @classmethod 151 @classmethod
149 def Name(cls): 152 def Name(cls):
150 return 'system_health.webview_startup' 153 return 'system_health.webview_startup'
OLDNEW
« no previous file with comments | « no previous file | tools/perf/benchmarks/system_health_smoke_test.py » ('j') | tools/perf/benchmarks/system_health_smoke_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698