Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2203223002: Revert "Separate deferred startup into tasks." (Closed)

Created:
4 years, 4 months ago by Ted C
Modified:
4 years, 4 months ago
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Separate deferred startup into tasks." This reverts commit b17794608da80ccba64795658fac6239bdae6510. Suspect for CustomTab test breakage: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35551/steps/chrome_public_test_apk/logs/stdio TBR=wnwen@chromium.org,asvitkine@chromium.org NOTRY=true BUG=614452 Committed: https://crrev.com/6a1eaba440bff87eca6ed9a3f7cadc1f5c6ef5f2 Cr-Commit-Position: refs/heads/master@{#409390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -346 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 6 chunks +48 lines, -45 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +25 lines, -49 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 8 chunks +55 lines, -145 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaUtils.java View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/FullscreenTestUtils.java View 2 chunks +1 line, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 8 chunks +0 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203223002/1
4 years, 4 months ago (2016-08-03 00:05:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 00:11:25 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 00:13:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6a1eaba440bff87eca6ed9a3f7cadc1f5c6ef5f2
Cr-Commit-Position: refs/heads/master@{#409390}

Powered by Google App Engine
This is Rietveld 408576698