Revert "Separate deferred startup into tasks."

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.app.assist.AssistContent;
 import android.content.Context;
 import android.content.Intent;
 import android.content.res.Configuration;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.Rect;
 import android.graphics.drawable.ColorDrawable;
 import android.graphics.drawable.Drawable;
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
+import android.os.Looper;
+import android.os.MessageQueue;
 import android.os.SystemClock;
 import android.support.v7.app.AlertDialog;
 import android.util.DisplayMetrics;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewConfiguration;
 import android.view.ViewGroup;
 import android.view.ViewStub;
 import android.view.Window;
@@ skipping 118 matching lines @@
          */
         public AppMenuHandler get(Activity activity, AppMenuPropertiesDelegate delegate,
                 int menuResourceId);
     }
 
     /**
      * No control container to inflate during initialization.
      */
     static final int NO_CONTROL_CONTAINER = -1;
 
+    /** Delay in ms after first page load finishes before we initiate deferred startup actions. */
+    private static final int DEFERRED_STARTUP_DELAY_MS = 1000;
+
     private static final int RECORD_MULTI_WINDOW_SCREEN_WIDTH_DELAY_MS = 5000;
 
     /**
      * Timeout in ms for reading PartnerBrowserCustomizations provider.
      */
     private static final int PARTNER_BROWSER_CUSTOMIZATIONS_TIMEOUT_MS = 10000;
     private static final String TAG = "ChromeActivity";
     private static final Rect EMPTY_RECT = new Rect();
 
     private TabModelSelector mTabModelSelector;
     private TabModelSelectorTabObserver mTabModelSelectorTabObserver;
     private TabCreatorManager.TabCreator mRegularTabCreator;
     private TabCreatorManager.TabCreator mIncognitoTabCreator;
     private TabContentManager mTabContentManager;
     private UmaSessionStats mUmaSessionStats;
     private ContextReporter mContextReporter;
     protected GSAServiceClient mGSAServiceClient;
 
     private boolean mPartnerBrowserRefreshNeeded;
 
     protected IntentHandler mIntentHandler;
 
-    private boolean mDeferredStartupPosted;
+    /** Whether onDeferredStartup() has been run. */
+    private boolean mDeferredStartupNotified;
 
     // The class cannot implement TouchExplorationStateChangeListener,
     // because it is only available for Build.VERSION_CODES.KITKAT and later.
     // We have to instantiate the TouchExplorationStateChangeListner object in the code.
     @SuppressLint("NewApi")
     private TouchExplorationStateChangeListener mTouchExplorationStateChangeListener;
 
     // Observes when sync becomes ready to create the mContextReporter.
     private ProfileSyncService.SyncStateChangedListener mSyncStateChangedListener;
 
@@ skipping 12 matching lines @@
     // Time in ms that it took took us to inflate the initial layout
     private long mInflateInitialLayoutDurationMs;
 
     private int mScreenWidthDp;
     private Runnable mRecordMultiWindowModeScreenWidthRunnable;
 
     private AssistStatusHandler mAssistStatusHandler;
 
     // A set of views obscuring all tabs. When this set is nonempty,
     // all tab content will be hidden from the accessibility tree.
-    private List<View> mViewsObscuringAllTabs = new ArrayList<>();
+    private List<View> mViewsObscuringAllTabs = new ArrayList<View>();
 
     private static AppMenuHandlerFactory sAppMenuHandlerFactory = new AppMenuHandlerFactory() {
         @Override
         public AppMenuHandler get(
                 Activity activity, AppMenuPropertiesDelegate delegate, int menuResourceId) {
             return new AppMenuHandler(activity, delegate, menuResourceId);
         }
     };
 
     // See enableHardwareAcceleration()
@@ skipping 449 matching lines @@
         mIntentHandler.onNewIntent(this, intent);
     }
 
     /**
      * @return Whether the given activity contains a CustomTab.
      */
     public boolean isCustomTab() {
         return false;
     }
 
-    /**
-     * Overriding methods should queue tasks on the DeferredStartupHandler before or after calling
-     * super depending on whether the tasks should run before or after these ones.
-     */
     @Override
     protected void onDeferredStartup() {
         super.onDeferredStartup();
-        initDeferredStartupForActivity();
-        DeferredStartupHandler.getInstance().initDeferredStartupForApp();
-        DeferredStartupHandler.getInstance().queueDeferredTasksOnIdleHandler();
+        DeferredStartupHandler.getInstance().onDeferredStartupForApp();
+        onDeferredStartupForActivity();
     }
 
     /**
      * All deferred startup tasks that require the activity rather than the app should go here.
      */
-    private void initDeferredStartupForActivity() {
-        DeferredStartupHandler.getInstance().addDeferredTask(new Runnable() {
+    private void onDeferredStartupForActivity() {
+        BeamController.registerForBeam(this, new BeamProvider() {
             @Override
-            public void run() {
-                if (isActivityDestroyed()) return;
-                BeamController.registerForBeam(ChromeActivity.this, new BeamProvider() {
-                    @Override
-                    public String getTabUrlForBeam() {
-                        if (isOverlayVisible()) return null;
-                        if (getActivityTab() == null) return null;
-                        return getActivityTab().getUrl();
-                    }
-                });
-
-                UpdateMenuItemHelper.getInstance().checkForUpdateOnBackgroundThread(
-                        ChromeActivity.this);
+            public String getTabUrlForBeam() {
+                if (isOverlayVisible()) return null;
+                if (getActivityTab() == null) return null;
+                return getActivityTab().getUrl();
             }
         });
 
-        DeferredStartupHandler.getInstance().addDeferredTask(new Runnable() {
-            @Override
-            public void run() {
-                if (isActivityDestroyed()) return;
-                if (mToolbarManager != null) {
-                    String simpleName = getClass().getSimpleName();
-                    RecordHistogram.recordTimesHistogram(
-                            "MobileStartup.ToolbarInflationTime." + simpleName,
-                            mInflateInitialLayoutDurationMs, TimeUnit.MILLISECONDS);
-                    mToolbarManager.onDeferredStartup(getOnCreateTimestampMs(), simpleName);
-                }
+        UpdateMenuItemHelper.getInstance().checkForUpdateOnBackgroundThread(this);
 
-                if (MultiWindowUtils.getInstance().isInMultiWindowMode(ChromeActivity.this)) {
-                    onDeferredStartupForMultiWindowMode();
-                }
-            }
-        });
+        if (mToolbarManager != null) {
+            String simpleName = getClass().getSimpleName();
+            RecordHistogram.recordTimesHistogram("MobileStartup.ToolbarInflationTime." + simpleName,
+                    mInflateInitialLayoutDurationMs, TimeUnit.MILLISECONDS);
+            mToolbarManager.onDeferredStartup(getOnCreateTimestampMs(), simpleName);
+        }
+
+        if (MultiWindowUtils.getInstance().isInMultiWindowMode(this)) {
+            onDeferredStartupForMultiWindowMode();
+        }
     }
 
     /**
      * Actions that may be run at some point after startup for Android N multi-window mode. Should
      * be called from #onDeferredStartup() if the activity is in multi-window mode.
      */
     protected void onDeferredStartupForMultiWindowMode() {
         // If the Activity was launched in multi-window mode, record a user action and the screen
         // width.
         recordMultiWindowModeChangedUserAction(true);
@@ skipping 900 matching lines @@
 
     private int displayArea() {
         if (getResources() != null && getResources().getDisplayMetrics() != null) {
             DisplayMetrics metrics = getResources().getDisplayMetrics();
             return metrics.heightPixels * metrics.widthPixels;
         }
         return -1;
     }
 
     protected final void postDeferredStartupIfNeeded() {
-        if (!mDeferredStartupPosted) {
-            mDeferredStartupPosted = true;
+        if (!mDeferredStartupNotified) {
             RecordHistogram.recordLongTimesHistogram(
-                    "UMA.Debug.EnableCrashUpload.PostDeferredStartUptime2",
-                    SystemClock.uptimeMillis() - UmaUtils.getForegroundStartTime(),
+                    "UMA.Debug.EnableCrashUpload.PostDeferredStartUptime",
+                    SystemClock.uptimeMillis() - UmaUtils.getMainEntryPointTime(),
                     TimeUnit.MILLISECONDS);
-            onDeferredStartup();
+
+            // We want to perform deferred startup tasks a short time after the first page
+            // load completes, but only when the main thread Looper has become idle.
+            mHandler.postDelayed(new Runnable() {
+                @Override
+                public void run() {
+                    if (!mDeferredStartupNotified && !isActivityDestroyed()) {
+                        mDeferredStartupNotified = true;
+                        Looper.myQueue().addIdleHandler(new MessageQueue.IdleHandler() {
+                            @Override
+                            public boolean queueIdle() {
+                                onDeferredStartup();
+                                return false;  // Remove this idle handler.
+                            }
+                        });
+                    }
+                }
+            }, DEFERRED_STARTUP_DELAY_MS);
         }
     }
 
     /**
      * Determines whether the ContentView is currently visible and not hidden by an overlay
      * @return true if the ContentView is fully hidden by another view (i.e. the tab stack)
      */
     public boolean isOverlayVisible() {
         return false;
     }
@@ skipping 75 matching lines @@
                 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
                 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
 
         if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
             RecordHistogram.recordLinearCountHistogram(
                     "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
                     DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
         }
     }
 }