Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2203173002: Use unitMember/classMember/parameter names instead of offsets in index. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use unitMember/classMember/parameter names instead of offsets in index. This fixes index for cases when element offset might change without causing resolution of its users, e.g. incremental changes (like inserting a whitespace) and incremental invalidation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/77590f5ab1c085b68c16e59cad187acde19a1491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -129 lines) Patch
M pkg/analysis_server/lib/src/services/index/index.dart View 2 chunks +60 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 10 chunks +86 lines, -20 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +24 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 10 chunks +161 lines, -90 lines 0 comments Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 1 chunk +24 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-02 20:40:38 UTC) #1
Brian Wilkerson
One of the advantages of the old implementation was that we could handle errors such ...
4 years, 4 months ago (2016-08-02 21:51:47 UTC) #2
scheglov
4 years, 4 months ago (2016-08-03 06:18:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77590f5ab1c085b68c16e59cad187acde19a1491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698