Use unitMember/classMember/parameter names instead of offsets in index.

pkg/analysis_server/lib/src/services/index/index.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
 import 'package:analyzer/src/generated/source.dart';
@@ skipping 323 matching lines @@
 class _PackageIndexRequester {
   final PackageIndex index;
 
   _PackageIndexRequester(this.index);
 
   /**
    * Return the [element]'s identifier in the [index] or `-1` if the
    * [element] is not referenced in the [index].
    */
   int findElementId(Element element) {
+    IndexElementInfo info = new IndexElementInfo(element);
+    element = info.element;
     // Find the id of the element's unit.
     int unitId = getUnitId(element);
     if (unitId == -1) {
       return -1;
     }
     // Prepare information about the element.
-    ElementInfo info = PackageIndexAssembler.newElementInfo(unitId, element);
-    // Find the first occurrence of an element with the same offset.
-    int elementId = _findFirstOccurrence(index.elementOffsets, info.offset);
+    int unitMemberId = getElementUnitMemberId(element);
+    if (unitMemberId == -1) {
+      return -1;
+    }
+    int classMemberId = getElementClassMemberId(element);
+    if (classMemberId == -1) {
+      return -1;
+    }
+    int parameterId = getElementParameterId(element);
+    if (parameterId == -1) {
+      return -1;
+    }
+    // Try to find the element id using classMemberId, parameterId, and kind.
+    int elementId =
+        _findFirstOccurrence(index.elementNameUnitMemberIds, unitMemberId);
     if (elementId == -1) {
       return -1;
     }
-    // Try to find the element id using offset, unit and kind.
     for (;
-        elementId < index.elementOffsets.length &&
-            index.elementOffsets[elementId] == info.offset;
+        elementId < index.elementNameUnitMemberIds.length &&
+            index.elementNameUnitMemberIds[elementId] == unitMemberId;
         elementId++) {
       if (index.elementUnits[elementId] == unitId &&
+          index.elementNameClassMemberIds[elementId] == classMemberId &&
+          index.elementNameParameterIds[elementId] == parameterId &&
           index.elementKinds[elementId] == info.kind) {
         return elementId;
       }
     }
     return -1;
   }
 
   /**
    * Complete with a list of locations where elements of the given [kind] with
    * names satisfying the given [regExp] are defined.
    */
   List<Location> getDefinedNames(
       AnalysisContext context, RegExp regExp, IndexNameKind kind) {
     List<Location> locations = <Location>[];
     for (UnitIndex unitIndex in index.units) {
       _UnitIndexRequester requester = new _UnitIndexRequester(this, unitIndex);
       List<Location> unitLocations =
           requester.getDefinedNames(context, regExp, kind);
       locations.addAll(unitLocations);
     }
     return locations;
   }
 
   /**
+   * Return the [element]'s class member name identifier, `null` is not a class
+   * member, or `-1` if the [element] is not referenced in the [index].
+   */
+  int getElementClassMemberId(Element element) {
+    for (; element != null; element = element.enclosingElement) {
+      if (element.enclosingElement is ClassElement) {
+        return getStringId(element.name);
+      }
+    }
+    return getStringId(PackageIndexAssembler.NULL_STRING);
+  }
+
+  /**
+   * Return the [element]'s class member name identifier, `null` is not a class
+   * member, or `-1` if the [element] is not referenced in the [index].
+   */
+  int getElementParameterId(Element element) {
+    for (; element != null; element = element.enclosingElement) {
+      if (element is ParameterElement) {
+        return getStringId(element.name);
+      }
+    }
+    return getStringId(PackageIndexAssembler.NULL_STRING);
+  }
+
+  /**
+   * Return the [element]'s top-level name identifier, `0` is the unit, or
+   * `-1` if the [element] is not referenced in the [index].
+   */
+  int getElementUnitMemberId(Element element) {
+    for (; element != null; element = element.enclosingElement) {
+      if (element.enclosingElement is CompilationUnitElement) {
+        return getStringId(element.name);
+      }
+    }
+    return getStringId(PackageIndexAssembler.NULL_STRING);
+  }
+
+  /**
    * Complete with a list of locations where the given [element] has relation
    * of the given [kind].
    */
   List<Location> getRelations(
       AnalysisContext context, Element element, IndexRelationKind kind) {
     int elementId = findElementId(element);
     if (elementId == -1) {
       return const <Location>[];
     }
     List<Location> locations = <Location>[];
@@ skipping 180 matching lines @@
           unitUnitUri,
           unitIndex.usedNameKinds[i],
           unitIndex.usedNameOffsets[i],
           name.length,
           unitIndex.usedNameIsQualifiedFlags[i],
           false));
     }
     return locations;
   }
 }