Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5463)

Unified Diff: chromecast/crash/linux/minidump_writer.h

Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: slan@ comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/dump_info_unittest.cc ('k') | chromecast/crash/linux/minidump_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/minidump_writer.h
diff --git a/chromecast/crash/linux/minidump_writer.h b/chromecast/crash/linux/minidump_writer.h
index e37dbaffb716c496cce5aeae89d34a3f49d696d1..c2381f68c16908c78a567fd23b40e6784c1f0fad 100644
--- a/chromecast/crash/linux/minidump_writer.h
+++ b/chromecast/crash/linux/minidump_writer.h
@@ -46,11 +46,11 @@ class MinidumpWriter : public SynchronizedMinidumpManager {
// Acquires exclusive access to the minidumps directory and generates a
// minidump and a log to be uploaded later. Returns 0 if successful, -1
// otherwise.
- int Write() { return AcquireLockAndDoWork(); }
+ int Write() { return AcquireLockAndDoWork() ? 0 : -1; }
protected:
// MinidumpManager implementation:
- int DoWork() override;
+ bool DoWork() override;
private:
MinidumpGenerator* const minidump_generator_;
« no previous file with comments | « chromecast/crash/linux/dump_info_unittest.cc ('k') | chromecast/crash/linux/minidump_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698