Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5027)

Unified Diff: chromecast/crash/linux/minidump_writer.cc

Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: slan@ comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/minidump_writer.h ('k') | chromecast/crash/linux/synchronized_minidump_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/minidump_writer.cc
diff --git a/chromecast/crash/linux/minidump_writer.cc b/chromecast/crash/linux/minidump_writer.cc
index cb79147dcccaf835f68e5464868c6a8a39a537a4..bd9e56f39a295d175b58bd25c22b5ee7eb3d683f 100644
--- a/chromecast/crash/linux/minidump_writer.cc
+++ b/chromecast/crash/linux/minidump_writer.cc
@@ -61,7 +61,7 @@ MinidumpWriter::MinidumpWriter(MinidumpGenerator* minidump_generator,
MinidumpWriter::~MinidumpWriter() {
}
-int MinidumpWriter::DoWork() {
+bool MinidumpWriter::DoWork() {
// If path is not absolute, append it to |dump_path_|.
if (!minidump_path_.value().empty() && minidump_path_.value()[0] != '/')
minidump_path_ = dump_path_.Append(minidump_path_);
@@ -70,33 +70,32 @@ int MinidumpWriter::DoWork() {
if (dump_path_ != minidump_path_.DirName()) {
LOG(INFO) << "The absolute path: " << minidump_path_.value() << " is not"
<< "in the correct directory: " << dump_path_.value();
- return -1;
+ return false;
}
// Generate a minidump at the specified |minidump_path_|.
if (!minidump_generator_->Generate(minidump_path_.value())) {
LOG(ERROR) << "Generate minidump failed " << minidump_path_.value();
- return -1;
+ return false;
}
// Run the dumpstate callback.
DCHECK(!dump_state_cb_.is_null());
if (dump_state_cb_.Run(minidump_path_.value()) < 0) {
LOG(ERROR) << "DumpState callback failed.";
- return -1;
+ return false;
}
// Add this entry to the lockfile.
const DumpInfo info(minidump_path_.value(),
minidump_path_.value() + kDumpStateSuffix,
- time(nullptr),
- params_);
- if (AddEntryToLockFile(info) < 0) {
+ base::Time::Now(), params_);
+ if (!AddEntryToLockFile(info)) {
LOG(ERROR) << "lockfile logging failed";
- return -1;
+ return false;
}
- return 0;
+ return true;
}
} // namespace crash_manager
« no previous file with comments | « chromecast/crash/linux/minidump_writer.h ('k') | chromecast/crash/linux/synchronized_minidump_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698