Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3527)

Unified Diff: chromecast/crash/linux/dump_info_unittest.cc

Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/linux/dump_info_unittest.cc
diff --git a/chromecast/crash/linux/dump_info_unittest.cc b/chromecast/crash/linux/dump_info_unittest.cc
index 03c46e1c571170a511c268d6f8be21b2df0c00d5..1e4d3814c3b579e7c7d2344cf64284155685bcc6 100644
--- a/chromecast/crash/linux/dump_info_unittest.cc
+++ b/chromecast/crash/linux/dump_info_unittest.cc
@@ -47,15 +47,14 @@ TEST(DumpInfoTest, AllRequiredFieldsIsValid) {
"\"uptime\": \"123456789\","
"\"logfile\": \"logfile.log\""
"}"));
- struct tm tm = {0};
- tm.tm_isdst = 0;
- tm.tm_sec = 1;
- tm.tm_min = 31;
- tm.tm_hour = 18;
- tm.tm_mday = 12;
- tm.tm_mon = 10;
- tm.tm_year = 101;
- time_t dump_time = mktime(&tm);
+ base::Time::Exploded ex = {0};
+ ex.second = 1;
+ ex.minute = 31;
+ ex.hour = 18;
+ ex.day_of_month = 12;
+ ex.month = 11;
+ ex.year = 2001;
+ base::Time dump_time = base::Time::FromLocalExploded(ex);
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
@@ -86,15 +85,14 @@ TEST(DumpInfoTest, SomeRequiredFieldsEmptyIsValid) {
"\"uptime\": \"\","
"\"logfile\": \"\""
"}"));
- struct tm tm = {0};
- tm.tm_isdst = 0;
- tm.tm_sec = 1;
- tm.tm_min = 31;
- tm.tm_hour = 18;
- tm.tm_mday = 12;
- tm.tm_mon = 10;
- tm.tm_year = 101;
- time_t dump_time = mktime(&tm);
+ base::Time::Exploded ex = {0};
+ ex.second = 1;
+ ex.minute = 31;
+ ex.hour = 18;
+ ex.day_of_month = 12;
+ ex.month = 11;
+ ex.year = 2001;
+ base::Time dump_time = base::Time::FromLocalExploded(ex);
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
@@ -120,15 +118,14 @@ TEST(DumpInfoTest, AllOptionalFieldsIsValid) {
"\"build_number\": \"BUILD_NUMBER\","
"\"reason\": \"foo\""
"}"));
- struct tm tm = {0};
- tm.tm_isdst = 0;
- tm.tm_sec = 1;
- tm.tm_min = 31;
- tm.tm_hour = 18;
- tm.tm_mday = 12;
- tm.tm_mon = 10;
- tm.tm_year = 101;
- time_t dump_time = mktime(&tm);
+ base::Time::Exploded ex = {0};
+ ex.second = 1;
+ ex.minute = 31;
+ ex.hour = 18;
+ ex.day_of_month = 12;
+ ex.month = 11;
+ ex.year = 2001;
+ base::Time dump_time = base::Time::FromLocalExploded(ex);
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
@@ -155,15 +152,14 @@ TEST(DumpInfoTest, SomeOptionalFieldsIsValid) {
"\"suffix\": \"suffix\","
"\"prev_app_name\": \"previous_app\""
"}"));
- struct tm tm = {0};
- tm.tm_isdst = 0;
- tm.tm_sec = 1;
- tm.tm_min = 31;
- tm.tm_hour = 18;
- tm.tm_mday = 12;
- tm.tm_mon = 10;
- tm.tm_year = 101;
- time_t dump_time = mktime(&tm);
+ base::Time::Exploded ex = {0};
+ ex.second = 1;
+ ex.minute = 31;
+ ex.hour = 18;
+ ex.day_of_month = 12;
+ ex.month = 11;
+ ex.year = 2001;
+ base::Time dump_time = base::Time::FromLocalExploded(ex);
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);

Powered by Google App Engine
This is Rietveld 408576698