Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6163)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager.h

Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/linux/synchronized_minidump_manager.h
diff --git a/chromecast/crash/linux/synchronized_minidump_manager.h b/chromecast/crash/linux/synchronized_minidump_manager.h
index ce4d9ebacc5dc155b4797d7950497030de174fc1..ad78ad74489c79eb230d95c11b541e73d31a1b47 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager.h
+++ b/chromecast/crash/linux/synchronized_minidump_manager.h
@@ -9,6 +9,7 @@
#include <string>
+#include "base/files/file.h"
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
@@ -54,12 +55,6 @@ class SynchronizedMinidumpManager {
virtual ~SynchronizedMinidumpManager();
- // Returns whether this object's file locking method is nonblocking or not.
- bool non_blocking() { return non_blocking_; }
-
- // Sets the file locking mechansim to be nonblocking or not.
- void set_non_blocking(bool non_blocking) { non_blocking_ = non_blocking; }
-
protected:
SynchronizedMinidumpManager();
@@ -111,9 +106,6 @@ class SynchronizedMinidumpManager {
// Used to avoid unnecessary file locks in consumers.
bool HasDumps();
- // If true, the flock on the lockfile will be nonblocking.
- bool non_blocking_;
-
// Cached path for the minidumps directory.
const base::FilePath dump_path_;
@@ -138,8 +130,8 @@ class SynchronizedMinidumpManager {
// Release the lock file with the associated *fd*.
void ReleaseLockFile();
- const std::string lockfile_path_;
- const std::string metadata_path_;
+ const base::FilePath lockfile_path_;
+ const base::FilePath metadata_path_;
int lockfile_fd_;
std::unique_ptr<base::Value> metadata_;
std::unique_ptr<base::ListValue> dumps_;

Powered by Google App Engine
This is Rietveld 408576698