Omnibox: Create DemoteByType Experiment

base/strings/string_split.h

Index: base/strings/string_split.h
diff --git a/base/strings/string_split.h b/base/strings/string_split.h
index 2803752d03e1ee4164388fabc1575f06bd3232e0..d86bb880c9cf4fa538bfd09b907859699f97d5a3 100644
--- a/base/strings/string_split.h
+++ b/base/strings/string_split.h
@@ -36,11 +36,13 @@ BASE_EXPORT bool SplitStringIntoKeyValues(const std::string& line,
                                           std::string* key,
                                           std::vector<std::string>* values);
 
+typedef std::vector<std::pair<std::string, std::string> > VectorOfKeyValuePairs;

[Peter Kasting, 2013/08/06 22:19:40]

Nit: "KeyValuePairs" is shorter, just as clear, and avoids encoding "vector"
into the typename which would suck if for some reason we e.g. made this return a
map or something someday.

Can you maybe file a cleanup bug that all code that calls this function can
begin using this typedef?

[Mark P, 2013/08/06 22:44:49]

Okay.
Will do.  Can you suggest a reviewer for the current strings change?  It
requires a global owner (there's no base/strings/ owner).  I'll mention this
followup bug once I get that reviewer.

[Peter Kasting, 2013/08/07 00:59:01]

Anyone in base/OWNERS.  For example, brettw.

+
 BASE_EXPORT bool SplitStringIntoKeyValuePairs(
     const std::string& line,
     char key_value_delimiter,
     char key_value_pair_delimiter,
-    std::vector<std::pair<std::string, std::string> >* kv_pairs);
+    VectorOfKeyValuePairs* kv_pairs);
 
 // The same as SplitString, but use a substring delimiter instead of a char.
 BASE_EXPORT void SplitStringUsingSubstr(const string16& str,