Omnibox: Create DemoteByType Experiment

base/strings/string_split.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_STRINGS_STRING_SPLIT_H_
 #define BASE_STRINGS_STRING_SPLIT_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 18 matching lines @@
 // Note: |c| must be in the ASCII range.
 BASE_EXPORT void SplitString(const std::string& str,
                              char c,
                              std::vector<std::string>* r);
 
 BASE_EXPORT bool SplitStringIntoKeyValues(const std::string& line,
                                           char key_value_delimiter,
                                           std::string* key,
                                           std::vector<std::string>* values);
 
+typedef std::vector<std::pair<std::string, std::string> > VectorOfKeyValuePairs;

[Peter Kasting, 2013/08/06 22:19:40]

Nit: "KeyValuePairs" is shorter, just as clear, and avoids encoding "vector"
into the typename which would suck if for some reason we e.g. made this return a
map or something someday.

Can you maybe file a cleanup bug that all code that calls this function can
begin using this typedef?

[Mark P, 2013/08/06 22:44:49]

Okay.
Will do.  Can you suggest a reviewer for the current strings change?  It
requires a global owner (there's no base/strings/ owner).  I'll mention this
followup bug once I get that reviewer.

[Peter Kasting, 2013/08/07 00:59:01]

Anyone in base/OWNERS.  For example, brettw.

+
 BASE_EXPORT bool SplitStringIntoKeyValuePairs(
     const std::string& line,
     char key_value_delimiter,
     char key_value_pair_delimiter,
-    std::vector<std::pair<std::string, std::string> >* kv_pairs);
+    VectorOfKeyValuePairs* kv_pairs);
 
 // The same as SplitString, but use a substring delimiter instead of a char.
 BASE_EXPORT void SplitStringUsingSubstr(const string16& str,
                                         const string16& s,
                                         std::vector<string16>* r);
 BASE_EXPORT void SplitStringUsingSubstr(const std::string& str,
                                         const std::string& s,
                                         std::vector<std::string>* r);
 
 // The same as SplitString, but don't trim white space.
@@ skipping 18 matching lines @@
 // characters defined by HTML 5). Each contiguous block of non-whitespace
 // characters is added to result.
 BASE_EXPORT void SplitStringAlongWhitespace(const string16& str,
                                             std::vector<string16>* result);
 BASE_EXPORT void SplitStringAlongWhitespace(const std::string& str,
                                             std::vector<std::string>* result);
 
 }  // namespace base
 
 #endif  // BASE_STRINGS_STRING_SPLIT_H_