Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2203033005: Remove references to DrawingFrame from RenderPassDrawQuad drawing. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp58_continue_rpdq_refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to DrawingFrame from RenderPassDrawQuad drawing. In most instances, a DrawingFrame is unnecessary for RenderPassDrawQuad drawing. The presence of a DrawingFrame assumes the existence of a RenderPass, which will not be true in the overlay copy path for RenderPassDrawQuads. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/200c53f59f06ec4a5b59ed0957b46456e5b3c329 Cr-Commit-Position: refs/heads/master@{#409573}

Patch Set 1 #

Patch Set 2 : Refactor error (duplicated line). #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -40 lines) Patch
M cc/output/gl_renderer.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 19 chunks +35 lines, -36 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
erikchen
ccameron: Please review.
4 years, 4 months ago (2016-08-03 17:11:13 UTC) #4
ccameron
lgtm
4 years, 4 months ago (2016-08-03 17:20:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033005/40001
4 years, 4 months ago (2016-08-03 17:24:52 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 18:22:03 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 18:24:57 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/200c53f59f06ec4a5b59ed0957b46456e5b3c329
Cr-Commit-Position: refs/heads/master@{#409573}

Powered by Google App Engine
This is Rietveld 408576698