Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2203033004: Only run _IsBuildFailureUniqueAcrossPlatforms if need_new_try_job is true. (Closed)

Created:
4 years, 4 months ago by josiahk
Modified:
4 years, 4 months ago
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Only run _IsBuildFailureUniqueAcrossPlatforms if need_new_try_job is true. BUG=633792 Committed: https://chromium.googlesource.com/infra/infra/+/9aa00e5cc809ffb596567e36a99349c92de2a7a3

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/infra/infra into key-error-fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M appengine/findit/waterfall/try_job_util.py View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
josiahk
Hi Jeff, Chan and Shuotao, Here is the fix for the KeyError issue in try_job_util._NeedANewTryJob! ...
4 years, 4 months ago (2016-08-03 00:09:27 UTC) #4
lijeffrey
lgtm
4 years, 4 months ago (2016-08-03 00:24:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033004/1
4 years, 4 months ago (2016-08-03 00:24:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30669b1692f44210) Infra Win ...
4 years, 4 months ago (2016-08-03 00:33:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033004/1
4 years, 4 months ago (2016-08-03 00:47:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3066b0cf6e20d610)
4 years, 4 months ago (2016-08-03 00:57:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033004/20001
4 years, 4 months ago (2016-08-03 00:59:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033004/20001
4 years, 4 months ago (2016-08-03 01:00:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033004/20001
4 years, 4 months ago (2016-08-03 01:00:59 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3066bc3f44262110)
4 years, 4 months ago (2016-08-03 01:08:53 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203033004/20001
4 years, 4 months ago (2016-08-03 02:56:19 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 03:09:52 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/9aa00e5cc809ffb596567e36a9934...

Powered by Google App Engine
This is Rietveld 408576698