Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3087)

Unified Diff: appengine/findit/waterfall/try_job_util.py

Issue 2203033004: Only run _IsBuildFailureUniqueAcrossPlatforms if need_new_try_job is true. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/infra/infra into key-error-fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 80c34fcbd343450860d1aa05c3463006f3fa88a2..eaa4209bf663a6f600d080d825e16ffdbfdb6733 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -318,16 +318,19 @@ def _NeedANewTryJob(
'step', master_name, builder_name, build_number, failure_result_map,
failed_steps))
- # TODO(josiahk): Integrate this into need_new_try_job boolean
- _IsBuildFailureUniqueAcrossPlatforms(
- master_name, builder_name, build_number, build_failure_type,
- builds[str(build_number)]['blame_list'], failed_steps, signals,
- heuristic_result)
need_new_try_job = (
need_new_try_job and ReviveOrCreateTryJobEntity(
master_name, builder_name, build_number, force_try_job))
+ # TODO(josiahk): Integrate _IsBuildFailureUniqueAcrossPlatforms() into
+ # need_new_try_job boolean
+ if need_new_try_job:
+ _IsBuildFailureUniqueAcrossPlatforms(
+ master_name, builder_name, build_number, build_failure_type,
+ builds[str(build_number)]['blame_list'], failed_steps, signals,
+ heuristic_result)
+
return need_new_try_job, last_pass, try_job_type, targeted_tests
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698